Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Daily plan creation popup, filters and sort #2737

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

GloireMutaliko21
Copy link
Member

No description provided.

@GloireMutaliko21 GloireMutaliko21 self-assigned this Jul 15, 2024
@GloireMutaliko21 GloireMutaliko21 added this to the v0.3.0 milestone Jul 15, 2024
@GloireMutaliko21 GloireMutaliko21 marked this pull request as ready for review July 15, 2024 16:33
@@ -104,14 +104,14 @@ export function CreateDailyPlanFormModal({
/>
)}

<InputField
{/* <InputField
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GloireMutaliko21 this supposed to be commented out? Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir @evereq I commented this field after long discuss with @KostyaEver. He told me that it not make sense to ask the user how much time he wants to work for future days. I suggested keeping the field but making it not required, but @KostyaEver wanted it to be hidden

Copy link
Member

@evereq evereq Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, interesting, so that field allowed to enter for any future days how much person thinks s/he will work? OR what was idea @GloireMutaliko21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it does not make any sense every time the user adds one task + asks about planned total hours. It's the wrong flow.

Ask about a day planned hours will be in a different way. NOT when a user adds a task to the 'Daily Plan'

@evereq

@evereq evereq merged commit 5695f89 into develop Jul 15, 2024
12 checks passed
@evereq evereq deleted the fix/daily-plan-creation-issue branch July 15, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants