Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#849 manage employees #864

Merged
merged 3 commits into from Mar 25, 2020
Merged

Feat/#849 manage employees #864

merged 3 commits into from Mar 25, 2020

Conversation

IronMan756
Copy link
Contributor

Added date picker to "edit-employee-employment.component", added field "startedWorkOn" in DB, reorganize inputs in "edit-employee-employment.component", tab Hiring was relocated
video:

https://www.loom.com/share/db9baf7af9944e8a83d44e1be0f8a669

@evereq
Copy link
Member

evereq commented Mar 25, 2020

@IronMan756 looks good, I will merge it now, but can you please:
a) fix DeepScan issues
b) watching your video it looks like you made that Work Start Date field kind of required? Because the "Save" button was disabled before you enter some value in start date input field. Maybe it was not clear in the task description, but we need that value to be optional and we just show that notification to user (warning) that some features will not be available, but it should be possible to SAVE form without that date (e.g. edit some other fields and save the form with an empty date for the start of work).
c) Please put It's required to enter the date when the employee started work to generate employee payroll, enable the employee to participate in split expenses, see employee statistics, etc as translation (into JSON file), similar to all other text

You can push all changes to the same branch and create again PR so we can merge it again.

Thank you, good work!

@evereq evereq marked this pull request as ready for review March 25, 2020 21:09
@evereq evereq merged commit 8ada1a9 into develop Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants