-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MessageHeaderType SessionID #16
Comments
Good observation. OpenV2G does not handle this particular case in the same manner, because this restriction on To successfully decode a stream which does not conform to the schema (by deviation of length), we would need to keep the The discussion would be whether we keep this flexibility (also for e.g. decoding non-conforming streams), or drop it with the variable, and introduce enforcements. Consider that, in the C world, both encoding and decoding use the same structs as API. In C++, you could consider restricting access in the encoder, and being tolerant in the decoder (with e.g. an error code class indicating a deviation, but not failure to decode the message). |
Thanks for your comments, I wasn't aware, that this changed from -2 to -20. Anyway, for compatibility reason, it should properly stay as it is for decoding. For encoding, the fixed length could be enforced, though. Best, |
Hi,
the
sessionIdType
has the following restriction:The generated
struct
representation hasIs there any reason, why the
SessionID
contains abytesLen
field. Shouldn't that be fixed to 8 anyway?I'm asking, because it seems that I need to set this field manually, although it should be always 8 in length. I know, OpenV2G handles it the same, but looking at the schema, it should be an error, if
bytesLen
would differ from 8.Or am I missing anything?
Best,
Anton
The text was updated successfully, but these errors were encountered: