EVG-16988 Update FindTestResults to handle new execution task logic #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
model/test_results.go
Outdated
| @@ -712,8 +720,24 @@ func FindTestResults(ctx context.Context, env cedar.Environment, opts FindTestRe | |||
| return nil, errors.Wrap(err, "invalid find options") | |||
| } | |||
|
|
|||
| var cur *mongo.Cursor | |||
There was a problem hiding this comment.
Nit:
var (
cur *mongo.Cursor
err error
)
julianedwards
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find test results will now do an aggregation for execution tasks and return previous executions as well
example
display_task {
et1: execution 0
et2: execution 0, 1
}
findTestResults(execution = 1) -> returns et1 exec0, et2 exec 1
findTestResults(execution = empty) -> returns et1 exec0, et2 exec 1 (latest for all exec tasks)
findTestResults(execution = 0) -> returns et1 exec0, et2 exec 0
This changes the return value for execution tasks so I'm not sure if this will break things on evergreen?