EVG-6425 hide reconfigure for commit queue patches (#2996)

evergreen-ci · Jan 2, 2020 · 5fda235 · 5fda235
1 parent 7329e4c
commit 5fda235
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/public/static/js/patches.js b/public/static/js/patches.js
@@ -35,7 +35,7 @@ mciModule.controller('PatchesController', function($scope, $filter, $http, $wind
       $scope.patches = data['UIPatches'];
 
       _.each($scope.patches, function(patch) {
-          patch.canEdit = ($window.user.Id === patch.Author ) || $window.isSuperUser
+          patch.canEdit = (($window.user.Id === patch.Author ) || $window.isSuperUser) && patch.alias !== "__commit_queue"
       });
 
       _.each($scope.buildsMap, function(buildArray) {

diff --git a/service/templates/patches.html b/service/templates/patches.html
@@ -58,7 +58,7 @@ <h1>
         &nbsp;]
       </span>
     </span>
-    <span ng-if="!patch.version">
+    <span ng-if="!patch.version && patch.canEdit">
       <a ng-href="/patch/[[patch.id]]" class="btn btn-info btn-sm">
         Configure
       </a>

diff --git a/service/version.go b/service/version.go
@@ -197,6 +197,7 @@ func (uis *UIServer) versionPage(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	canEdit := (currentUser != nil) && (projCtx.Version.Requester != evergreen.MergeTestRequester)
 	pluginContext := projCtx.ToPluginContext(uis.Settings, currentUser)
 	pluginContent := getPluginDataAndHTML(uis, plugin.VersionPage, pluginContext)
 
@@ -209,7 +210,7 @@ func (uis *UIServer) versionPage(w http.ResponseWriter, r *http.Request) {
 	}{
 		Version:       &versionAsUI,
 		PluginContent: pluginContent,
-		CanEdit:       currentUser != nil,
+		CanEdit:       canEdit,
 		JiraHost:      uis.Settings.Jira.Host,
 		ViewData:      uis.GetCommonViewData(w, r, false, true)}, "base", "version.html", "base_angular.html", "menu.html")
 }