Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-7549: error if creating sleep schedule that is always off #7921

Merged

Conversation

Kimchelly
Copy link
Contributor

DEVPROD-7549

Description

Explicitly prevent users from selecting a sleep schedule where the host is off 24/7. While this kind of schedule sounds kind of similar to the option to keep a host off indefinitely when stopping it, it's not really the same because the option to keep a host indefinitely off just means it'll stay off (and ignore the sleep schedule waking hours) until the user chooses to turn it back on. In contrast, a schedule that keeps a host off 24/7 means it should never be awake, and would logically prevent the user from ever turning on their host.

Testing

  • Tested in staging that trying to set this schedule from the UI produced a validation error.
  • Added unit test.

Documentation

N/A

@Kimchelly Kimchelly requested a review from a team May 24, 2024 17:52
@Kimchelly Kimchelly merged commit 38f9667 into evergreen-ci:main May 28, 2024
8 checks passed
@Kimchelly Kimchelly deleted the DEVPROD-7549_no_days_on_validation branch May 28, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants