EVG-18784 Warn users when creating/copying projects at limit #1681
Conversation
bynn
changed the title
Passing run #8233 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
src/gql/generated/types.ts
Outdated
| @@ -480,25 +480,6 @@ export type LogMessage = { | |||
| version?: Maybe<Scalars["Int"]>; | |||
| }; | |||
|
|
|||
| export type LogkeeperBuild = { | |||
There was a problem hiding this comment.
Can you make sure to run yarn codegen while checking out the most recent main branch in Evergreen? I don't think this should be getting deleted.
| @@ -29,7 +29,9 @@ export const CreateProjectModal: React.VFC<Props> = ({ | |||
| owner, | |||
| repo, | |||
| }) => { | |||
| const dispatchToast = useToastContext(); | |||
| // const dispatchToast = useToastContext(); | |||
| const { error: errorToast, success, warning } = useToastContext(); | |||
There was a problem hiding this comment.
we haven't been using this destructuring pattern for things like toasts. can we use the previous pattern?
| const [createProject, { called, data, error, loading }] = useMutation< | ||
| CreateProjectMutation, | ||
| CreateProjectMutationVariables | ||
| >(CREATE_PROJECT, { | ||
| onCompleted({ createProject: { identifier } }) { | ||
| dispatchToast.success(`Successfully created the project: ${identifier}`); | ||
| >(CREATE_PROJECT, { errorPolicy: "all" }); | ||
|
|
||
| useEffect(() => { | ||
| // onCompleted and onError don't provide sufficient information when used with errorPolicy: 'all', so use hook to manage behavior after confirming modal. | ||
| // https://github.com/apollographql/apollo-client/issues/6966 | ||
| if (!called || loading) { | ||
| return; | ||
| } | ||
|
|
||
| const identifier = data?.createProject?.identifier; | ||
| if (identifier) { | ||
| if (error) { | ||
| warning( | ||
| `The project was successfully created with the following errors: ${error.message}.`, | ||
| true, | ||
| { shouldTimeout: false } | ||
| ); | ||
| } else { | ||
| success(`Successfully created the project: ${identifier}`); | ||
| } |
There was a problem hiding this comment.
I'm confused by what you are trying to do here?
There was a problem hiding this comment.
if there is an error and the identifier is returned, we want to warn because the project was created but won't be able to be enabled
and it will error or not error normally.
sophie's pr might explain it better than me #1257
There was a problem hiding this comment.
Oh, interesting thank you for explaining. If this is a pattern we want to adopt maybe we should support it more officially. apollographql/apollo-client#6966 (comment) cc @sophstad
There was a problem hiding this comment.
I created EVG-19066 to standardize support for this pattern. I think this PR is fine as-is.
| }, | ||
| }); | ||
| } else if (error) { | ||
| errorToast(`There was an error creating the project: ${error?.message}`); |
There was a problem hiding this comment.
| errorToast(`There was an error creating the project: ${error?.message}`); | |
| dispatchToast.error(`There was an error creating the project: ${error?.message}`); |
| @@ -58,11 +58,13 @@ export const CopyProjectModal: React.VFC<Props> = ({ | |||
| { shouldTimeout: false } | |||
| ); | |||
| } else { | |||
| success(`Successfully created the project: ${identifier}`); | |||
| success(`Successfully duplicated the project: ${identifier}`); | |||
| @@ -58,11 +58,13 @@ export const CopyProjectModal: React.VFC<Props> = ({ | |||
| { shouldTimeout: false } | |||
| ); | |||
| } else { | |||
| success(`Successfully created the project: ${identifier}`); | |||
| success(`Successfully duplicated the project: ${identifier}`); | |||
There was a problem hiding this comment.
I know this was here before but can you refactor this to use the dispatchToast.status() pattern.
Just so we have consistent usage through out the code base.
EVG-18784
Description
users now get a warning when creating/copying projects if limit has been reached
Screenshots
Testing
added test
works on staging
Evergreen PR
evergreen-ci/evergreen#6259