Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-4798 remove ssh key field #2324

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 57 additions & 16 deletions src/gql/generated/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ export type AbortInfo = {
user: Scalars["String"]["output"];
};

export enum AccessLevel {
Admin = "ADMIN",
Edit = "EDIT",
View = "VIEW",
}

/**
* Annotation models the metadata that a user can add to a task.
* It is used as a field within the Task type.
Expand Down Expand Up @@ -382,7 +388,6 @@ export type Distro = {
providerSettingsList: Array<Scalars["Map"]["output"]>;
setup: Scalars["String"]["output"];
setupAsSudo: Scalars["Boolean"]["output"];
sshKey: Scalars["String"]["output"];
sshOptions: Array<Scalars["String"]["output"]>;
user: Scalars["String"]["output"];
userSpawnAllowed: Scalars["Boolean"]["output"];
Expand Down Expand Up @@ -447,7 +452,6 @@ export type DistroInput = {
providerSettingsList: Array<Scalars["Map"]["input"]>;
setup: Scalars["String"]["input"];
setupAsSudo: Scalars["Boolean"]["input"];
sshKey: Scalars["String"]["input"];
sshOptions: Array<Scalars["String"]["input"]>;
user: Scalars["String"]["input"];
userSpawnAllowed: Scalars["Boolean"]["input"];
Expand Down Expand Up @@ -501,6 +505,7 @@ export type EditSpawnHostInput = {
publicKey?: InputMaybe<PublicKeyInput>;
savePublicKey?: InputMaybe<Scalars["Boolean"]["input"]>;
servicePassword?: InputMaybe<Scalars["String"]["input"]>;
sleepSchedule?: InputMaybe<SleepScheduleInput>;
volume?: InputMaybe<Scalars["String"]["input"]>;
};

Expand Down Expand Up @@ -701,6 +706,7 @@ export type Host = {
persistentDnsName: Scalars["String"]["output"];
provider: Scalars["String"]["output"];
runningTask?: Maybe<TaskInfo>;
sleepSchedule?: Maybe<SleepSchedule>;
startedBy: Scalars["String"]["output"];
status: Scalars["String"]["output"];
tag: Scalars["String"]["output"];
Expand Down Expand Up @@ -1262,6 +1268,7 @@ export type MutationSchedulePatchTasksArgs = {

export type MutationScheduleTasksArgs = {
taskIds: Array<Scalars["String"]["input"]>;
versionId?: InputMaybe<Scalars["String"]["input"]>;
};

export type MutationScheduleUndispatchedBaseTasksArgs = {
Expand Down Expand Up @@ -1414,10 +1421,12 @@ export type ParsleyFilterInput = {
/** ParsleySettings contains information about a user's settings for Parsley. */
export type ParsleySettings = {
__typename?: "ParsleySettings";
jumpToFailingLineEnabled: Scalars["Boolean"]["output"];
sectionsEnabled: Scalars["Boolean"]["output"];
};

export type ParsleySettingsInput = {
jumpToFailingLineEnabled?: InputMaybe<Scalars["Boolean"]["input"]>;
sectionsEnabled?: InputMaybe<Scalars["Boolean"]["input"]>;
};

Expand Down Expand Up @@ -1685,6 +1694,7 @@ export type Project = {
isFavorite: Scalars["Boolean"]["output"];
manualPrTestingEnabled?: Maybe<Scalars["Boolean"]["output"]>;
notifyOnBuildFailure?: Maybe<Scalars["Boolean"]["output"]>;
oldestAllowedMergeBase: Scalars["String"]["output"];
owner: Scalars["String"]["output"];
parsleyFilters?: Maybe<Array<ParsleyFilter>>;
patchTriggerAliases?: Maybe<Array<PatchTriggerAlias>>;
Expand Down Expand Up @@ -1821,6 +1831,7 @@ export type ProjectInput = {
identifier?: InputMaybe<Scalars["String"]["input"]>;
manualPrTestingEnabled?: InputMaybe<Scalars["Boolean"]["input"]>;
notifyOnBuildFailure?: InputMaybe<Scalars["Boolean"]["input"]>;
oldestAllowedMergeBase?: InputMaybe<Scalars["String"]["input"]>;
owner?: InputMaybe<Scalars["String"]["input"]>;
parsleyFilters?: InputMaybe<Array<ParsleyFilterInput>>;
patchTriggerAliases?: InputMaybe<Array<PatchTriggerAliasInput>>;
Expand All @@ -1845,6 +1856,14 @@ export type ProjectInput = {
workstationConfig?: InputMaybe<WorkstationConfigInput>;
};

export enum ProjectPermission {
Annotations = "ANNOTATIONS",
Logs = "LOGS",
Patches = "PATCHES",
Settings = "SETTINGS",
Tasks = "TASKS",
}

export type ProjectPermissions = {
__typename?: "ProjectPermissions";
edit: Scalars["Boolean"]["output"];
Expand Down Expand Up @@ -1878,6 +1897,7 @@ export enum ProjectSettingsAccess {
export type ProjectSettingsInput = {
aliases?: InputMaybe<Array<ProjectAliasInput>>;
githubWebhooksEnabled?: InputMaybe<Scalars["Boolean"]["input"]>;
projectId?: InputMaybe<Scalars["String"]["input"]>;
projectRef?: InputMaybe<ProjectInput>;
subscriptions?: InputMaybe<Array<SubscriptionInput>>;
vars?: InputMaybe<ProjectVarsInput>;
Expand Down Expand Up @@ -2015,7 +2035,8 @@ export type QueryGithubProjectConflictsArgs = {
};

export type QueryHasVersionArgs = {
id: Scalars["String"]["input"];
id?: InputMaybe<Scalars["String"]["input"]>;
patchId?: InputMaybe<Scalars["String"]["input"]>;
};

export type QueryHostArgs = {
Expand Down Expand Up @@ -2051,7 +2072,8 @@ export type QueryMainlineCommitsArgs = {
};

export type QueryPatchArgs = {
id: Scalars["String"]["input"];
id?: InputMaybe<Scalars["String"]["input"]>;
patchId?: InputMaybe<Scalars["String"]["input"]>;
};

export type QueryPodArgs = {
Expand All @@ -2074,12 +2096,14 @@ export type QueryProjectSettingsArgs = {

export type QueryRepoEventsArgs = {
before?: InputMaybe<Scalars["Time"]["input"]>;
id: Scalars["String"]["input"];
id?: InputMaybe<Scalars["String"]["input"]>;
limit?: InputMaybe<Scalars["Int"]["input"]>;
repoId?: InputMaybe<Scalars["String"]["input"]>;
};

export type QueryRepoSettingsArgs = {
id: Scalars["String"]["input"];
id?: InputMaybe<Scalars["String"]["input"]>;
repoId?: InputMaybe<Scalars["String"]["input"]>;
};

export type QueryTaskArgs = {
Expand All @@ -2106,7 +2130,8 @@ export type QueryUserArgs = {
};

export type QueryVersionArgs = {
id: Scalars["String"]["input"];
id?: InputMaybe<Scalars["String"]["input"]>;
versionId?: InputMaybe<Scalars["String"]["input"]>;
};

export type RepoCommitQueueParams = {
Expand Down Expand Up @@ -2143,6 +2168,7 @@ export type RepoRef = {
id: Scalars["String"]["output"];
manualPrTestingEnabled: Scalars["Boolean"]["output"];
notifyOnBuildFailure: Scalars["Boolean"]["output"];
oldestAllowedMergeBase: Scalars["String"]["output"];
owner: Scalars["String"]["output"];
parsleyFilters?: Maybe<Array<ParsleyFilter>>;
patchTriggerAliases?: Maybe<Array<PatchTriggerAlias>>;
Expand Down Expand Up @@ -2186,6 +2212,7 @@ export type RepoRefInput = {
id: Scalars["String"]["input"];
manualPrTestingEnabled?: InputMaybe<Scalars["Boolean"]["input"]>;
notifyOnBuildFailure?: InputMaybe<Scalars["Boolean"]["input"]>;
oldestAllowedMergeBase?: InputMaybe<Scalars["String"]["input"]>;
owner?: InputMaybe<Scalars["String"]["input"]>;
parsleyFilters?: InputMaybe<Array<ParsleyFilterInput>>;
patchTriggerAliases?: InputMaybe<Array<PatchTriggerAliasInput>>;
Expand Down Expand Up @@ -2228,6 +2255,7 @@ export type RepoSettingsInput = {
aliases?: InputMaybe<Array<ProjectAliasInput>>;
githubWebhooksEnabled?: InputMaybe<Scalars["Boolean"]["input"]>;
projectRef?: InputMaybe<RepoRefInput>;
repoId?: InputMaybe<Scalars["String"]["input"]>;
subscriptions?: InputMaybe<Array<SubscriptionInput>>;
vars?: InputMaybe<ProjectVarsInput>;
};
Expand Down Expand Up @@ -2280,12 +2308,6 @@ export enum RoundingRule {
Up = "UP",
}

export type SshKey = {
__typename?: "SSHKey";
location: Scalars["String"]["output"];
name: Scalars["String"]["output"];
};

/** SaveDistroInput is the input to the saveDistro mutation. */
export type SaveDistroInput = {
distro: DistroInput;
Expand Down Expand Up @@ -2337,6 +2359,27 @@ export type SlackConfig = {
name?: Maybe<Scalars["String"]["output"]>;
};

export type SleepSchedule = {
__typename?: "SleepSchedule";
dailyStartTime: Scalars["String"]["output"];
dailyStopTime: Scalars["String"]["output"];
permanentlyExempt: Scalars["Boolean"]["output"];
shouldKeepOff: Scalars["Boolean"]["output"];
temporarilyExemptUntil?: Maybe<Scalars["Time"]["output"]>;
timeZone: Scalars["String"]["output"];
wholeWeekdaysOff: Array<Scalars["Int"]["output"]>;
};

export type SleepScheduleInput = {
dailyStartTime: Scalars["String"]["input"];
dailyStopTime: Scalars["String"]["input"];
permanentlyExempt: Scalars["Boolean"]["input"];
shouldKeepOff: Scalars["Boolean"]["input"];
temporarilyExemptUntil?: InputMaybe<Scalars["Time"]["input"]>;
timeZone: Scalars["String"]["input"];
wholeWeekdaysOff: Array<Scalars["Int"]["input"]>;
};

export enum SortDirection {
Asc = "ASC",
Desc = "DESC",
Expand Down Expand Up @@ -2376,6 +2419,7 @@ export type SpawnHostInput = {
region: Scalars["String"]["input"];
savePublicKey: Scalars["Boolean"]["input"];
setUpScript?: InputMaybe<Scalars["String"]["input"]>;
sleepSchedule?: InputMaybe<SleepScheduleInput>;
spawnHostsStartedByTask?: InputMaybe<Scalars["Boolean"]["input"]>;
taskId?: InputMaybe<Scalars["String"]["input"]>;
taskSync?: InputMaybe<Scalars["Boolean"]["input"]>;
Expand Down Expand Up @@ -2415,7 +2459,6 @@ export type SpruceConfig = {
containerPools?: Maybe<ContainerPoolsConfig>;
githubOrgs: Array<Scalars["String"]["output"]>;
jira?: Maybe<JiraConfig>;
keys: Array<SshKey>;
providers?: Maybe<CloudProviderConfig>;
secretFields: Array<Scalars["String"]["output"]>;
slack?: Maybe<SlackConfig>;
Expand Down Expand Up @@ -5771,7 +5814,6 @@ export type DistroQuery = {
providerSettingsList: Array<any>;
setup: string;
setupAsSudo: boolean;
sshKey: string;
sshOptions: Array<string>;
user: string;
userSpawnAllowed: boolean;
Expand Down Expand Up @@ -8189,7 +8231,6 @@ export type SpruceConfigQuery = {
email?: string | null;
host?: string | null;
} | null;
keys: Array<{ __typename?: "SSHKey"; location: string; name: string }>;
providers?: {
__typename?: "CloudProviderConfig";
aws?: {
Expand Down
6 changes: 0 additions & 6 deletions src/gql/mocks/getSpruceConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@ export const getSpruceConfigMock: ApolloMock<
},
],
},
keys: [
{
name: "fake_key",
location: "/path/to/key",
},
],
jira: {
host: "jira.mongodb.org",
__typename: "JiraConfig",
Expand Down
1 change: 0 additions & 1 deletion src/gql/queries/distro.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ query Distro($distroId: String!) {
providerSettingsList
setup
setupAsSudo
sshKey
sshOptions
user
userSpawnAllowed
Expand Down
4 changes: 0 additions & 4 deletions src/gql/queries/spruce-config.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ query SpruceConfig {
email
host
}
keys {
location
name
}
providers {
aws {
maxVolumeSizePerUser
Expand Down
8 changes: 2 additions & 6 deletions src/pages/distroSettings/tabs/HostTab/HostTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,12 @@ import { useMemo } from "react";
import { ValidateProps } from "components/SpruceForm";
import { DistroSettingsTabRoutes } from "constants/routes";
import { BootstrapMethod, CommunicationMethod } from "gql/generated/types";
import { useSpruceConfig } from "hooks";
import { useDistroSettingsContext } from "pages/distroSettings/Context";
import { BaseTab } from "../BaseTab";
import { getFormSchema } from "./getFormSchema";
import { HostFormState, TabProps } from "./types";

export const HostTab: React.FC<TabProps> = ({ distroData, provider }) => {
const spruceConfig = useSpruceConfig();
const sshKeys = spruceConfig?.keys;

const { getTab } = useDistroSettingsContext();
// @ts-expect-error - see TabState for details.
const { formData }: { formData: HostFormState } = getTab(
Expand All @@ -20,8 +16,8 @@ export const HostTab: React.FC<TabProps> = ({ distroData, provider }) => {
const architecture = formData?.setup?.arch;

const formSchema = useMemo(
() => getFormSchema({ architecture, provider, sshKeys }),
[architecture, provider, sshKeys],
() => getFormSchema({ architecture, provider }),
[architecture, provider],
);

return (
Expand Down
14 changes: 6 additions & 8 deletions src/pages/distroSettings/tabs/HostTab/getFormSchema.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { GetFormSchema } from "components/SpruceForm";
import { Arch, BootstrapMethod, Provider, SshKey } from "gql/generated/types";
import { Arch, BootstrapMethod, Provider } from "gql/generated/types";
import { nonWindowsArchitectures, windowsArchitectures } from "./constants";
import {
allocation as allocationProperties,
Expand All @@ -15,13 +15,11 @@ import {
type FormSchemaParams = {
architecture: Arch;
provider: Provider;
sshKeys: SshKey[];
};

export const getFormSchema = ({
architecture,
provider,
sshKeys,
}: FormSchemaParams): ReturnType<GetFormSchema> => {
const hasStaticProvider = provider === Provider.Static;
const hasDockerProvider = provider === Provider.Docker;
Expand Down Expand Up @@ -102,7 +100,7 @@ export const getFormSchema = ({
bootstrapMethod: { enum: [BootstrapMethod.LegacySsh] },
},
},
sshConfig: sshConfig(sshKeys),
sshConfig,
allocation,
},
},
Expand All @@ -116,7 +114,7 @@ export const getFormSchema = ({
},
},
bootstrapSettings,
sshConfig: sshConfig(sshKeys),
sshConfig,
allocation,
},
},
Expand All @@ -142,11 +140,11 @@ const bootstrapSettings = {
properties: bootstrapProperties.schema,
};

const sshConfig = (sshKeys: SshKey[]) => ({
const sshConfig = {
type: "object" as "object",
title: "SSH Configuration",
properties: sshConfigProperties.schema(sshKeys),
});
properties: sshConfigProperties.schema,
};

const allocation = {
type: "object" as "object",
Expand Down
Loading
Loading