New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search modifications #5
Closed
smyers1243
wants to merge
4
commits into
evergreen-library-system:master
from
smyers1243:search_modifications
Closed
Search modifications #5
smyers1243
wants to merge
4
commits into
evergreen-library-system:master
from
smyers1243:search_modifications
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd fully normalized phrases are searched for when using the TPAC
…Evergreen into search_modifications Merging feature branch with master.
…Evergreen into search_modifications
I'm reading a co workers e-mail about signing off commits. I'm sorry for not adding a sign off to these commits. I am confused on how to move forward. Can I remove this pull request to sign off on it? Can I add another pull request that is signed off? Any help would be greatly appreciated. Git sign offs are new to me. |
gmcharlt
pushed a commit
that referenced
this pull request
May 19, 2017
…reation Test plan --------- [1] Navigate to Cataloging -> Create New MARC Record. [2] Choose a template, click Load [3] Enter data in a fixed field, for example, Date1 [4] Enter data in a MARC field such as 100 [5] Click Create Record: The "This tab may have unsaved data. ..." pop up will appear. Clicking OK will save the record and take the user to their default view of the record. Clicking Cancel will save the record and return the user to the MARC Edit screen. The behavior when clicking Cancel can lead to confusion as to whether the record has actually been saved. [6] Apply the patch and repeats steps #1-#5. [7] This time, no extraneous unsaved data warning should appear. Note that this patch's kludge doesn't fix all possible instances of the warning; see https://bugs.launchpad.net/evergreen/+bug/1491875/comments/6 for details. Signed-off-by: Jason Etheridge <jason@esilibrary.com> SIgned-off-by: Andrea Neiman <abneiman@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
gmcharlt
pushed a commit
that referenced
this pull request
May 19, 2017
…reation Test plan --------- [1] Navigate to Cataloging -> Create New MARC Record. [2] Choose a template, click Load [3] Enter data in a fixed field, for example, Date1 [4] Enter data in a MARC field such as 100 [5] Click Create Record: The "This tab may have unsaved data. ..." pop up will appear. Clicking OK will save the record and take the user to their default view of the record. Clicking Cancel will save the record and return the user to the MARC Edit screen. The behavior when clicking Cancel can lead to confusion as to whether the record has actually been saved. [6] Apply the patch and repeats steps #1-#5. [7] This time, no extraneous unsaved data warning should appear. Note that this patch's kludge doesn't fix all possible instances of the warning; see https://bugs.launchpad.net/evergreen/+bug/1491875/comments/6 for details. Signed-off-by: Jason Etheridge <jason@esilibrary.com> SIgned-off-by: Andrea Neiman <abneiman@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
gmcharlt
pushed a commit
that referenced
this pull request
May 19, 2017
…reation Test plan --------- [1] Navigate to Cataloging -> Create New MARC Record. [2] Choose a template, click Load [3] Enter data in a fixed field, for example, Date1 [4] Enter data in a MARC field such as 100 [5] Click Create Record: The "This tab may have unsaved data. ..." pop up will appear. Clicking OK will save the record and take the user to their default view of the record. Clicking Cancel will save the record and return the user to the MARC Edit screen. The behavior when clicking Cancel can lead to confusion as to whether the record has actually been saved. [6] Apply the patch and repeats steps #1-#5. [7] This time, no extraneous unsaved data warning should appear. Note that this patch's kludge doesn't fix all possible instances of the warning; see https://bugs.launchpad.net/evergreen/+bug/1491875/comments/6 for details. Signed-off-by: Jason Etheridge <jason@esilibrary.com> SIgned-off-by: Andrea Neiman <abneiman@equinoxinitiative.org> Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evergreen feature for search modifications see wiki for more information.
Wiki: http://evergreen-ils.org/dokuwiki/doku.php?id=dev:proposal:search_modifications
Blueprint: https://blueprints.launchpad.net/evergreen/+spec/search-modifications
Jeffrey Bond
Catalyst IT Services
Developer
jBond@catalystitservices.com
503 730 8250