Update checkin modifiers - 3.3 #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to 3.3
Updated checkin modifiers to include Manual Float Active and Update Inventory and their descriptions. For 3.3
|
@katiegmartin Thanks for working on this. I'm ready to push it in, but was confused by this image file that is included: docs/media/circulation_patron_records-1c_web_client.png It looks identical to it's "1b" counterpart, it seems unrelated to this pull request, and I don't see this "1c" version included in the asciidoc files anywhere. Was it included by accident? |
|
Huh! That wasn't a part of the changes I made for this pull request. That
was part of the work I did at the conference last year--not sure why it
didn't disappear when I re-forked from Master. Do you want me to delete it
and submit a new pull request?
…On Thu, Apr 25, 2019 at 11:04 AM remocrevo ***@***.***> wrote:
@katiegmartin <https://github.com/katiegmartin> Thanks for working on
this. I'm ready to push it in, but was confused by this image file that is
included:
docs/media/circulation_patron_records-1c_web_client.png
It looks identical to it's "1b" counterpart, it seems unrelated to this
pull request, and I don't see this "1c" version included in the asciidoc
files anywhere. Was it included by accident?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJIQ4BLT55HZSBRYIAIUE6LPSHB7BANCNFSM4HIHAODA>
.
--
Katie Greenleaf Martin, MLIS
bcl@blaircountylibraries.org
814.946.0417x132
County Coordinator
Blair County Library System
|
|
No worries, I will remove that file before I push it in. |
|
Perfect, thanks!! |
|
Pushed to master and 3.3. I chose not to backport to earlier versions, since the screenshots include the 3.3-only feature. I might add just the wording to 3.2 and 3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated checkin modifiers to include Manual Floating Active and Update Inventory with descriptions. Updated screenshot in media file & file path corrected in doc. The Update Inventory is only available in 3.3. Manual Floating Active goes back to 2.9 I think but was not in the web client circulating items doc.