Fixing #116, 'not' in strings. #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix will clear the issue that I got when using "not" blocks for validation of string.
Example would be to add forbidden values (not enum) or anti-patterns (not pattern).
Implementation should be quite straight forwards, and be implementing "not" as a complete schema of its own - using the existing "NotSchema" class to validate the schema.
|
Thank you for your efforts, but I can't merge it. It is just a symptom of a deeper and more general problem. I added my explanation here: #116 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix will clear the issue that I got when using "not" blocks for validation of string.
Example would be to add forbidden values (not enum) or anti-patterns (not pattern).
Implementation should be quite straight forwards, and be implementing "not" as a complete schema of its own - using the existing "NotSchema" class to validate the schema.