Issue 160 #166
Merged
Issue 160 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maLoader. As specVersion can be given in metaschema there is no point to add defaultFormatValidators at the point when specVersion is set. That step can be executed at the point when schemaloader is built.
erosb
requested changes
Apr 16, 2018
| // this.formatValidators = new HashMap<>(specVersion.defaultFormatValidators()); | ||
| } | ||
|
|
||
| private Optional<SpecificationVersion> specVersionInMetaSchema() { |
There was a problem hiding this comment.
I think it should be called specVersionInSchema()
| Object schemaValue = schemaObj.get("$schema"); | ||
| if (schemaValue != null) { | ||
| specVersion = Optional.of(SpecificationVersion.getByMetaSchemaUrl((String) schemaValue)); | ||
| } |
There was a problem hiding this comment.
The above 4 lines could be simplified to specVersion = Optional.ofNullable(schemaObj.getString("$schema")).map((SpecificationVersion::getByMetaSchemaUrl))
There was a problem hiding this comment.
Small modification: schemaObj.get("$schema") instead of getString and a cast to String.
|
The root cause of the problem is that default format validators are set at the point when the specversion is also set explicitly by the builder (draftV6Support,...). If the specversion is defined by $schema the format validators are not set accordingly because it is checked at a later point (in the constructor of SchemaLoader). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.