Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to uninstall with current API #25

Closed
WillsterJohnson opened this issue Jan 21, 2023 · 2 comments
Closed

Impossible to uninstall with current API #25

WillsterJohnson opened this issue Jan 21, 2023 · 2 comments

Comments

@WillsterJohnson
Copy link

 uninstall() {
    if (existsSync(this._getInstallDirectory())) {
      rimraf.sync(this.installDirectory);
      console.log(
        `${this.name ? this.name : "Your package"} has been uninstalled`
      );
    }
  }

This code was removed in a refactor and never reintroduced.
Was this intentional?

@vladdoroniuk
Copy link

That file seems kinda useless to me. Thanks to this package, I've managed to successfully distribute my own Rust-based binary through the NPM registry, and so far there are no problems with installing/reinstalling/uninstalling it via yarn/npm.

@EverlastingBugstopper
Copy link
Owner

uninstall logic was removed, yes - that code never ended up getting called and uninstalls/re-installs can be handled with npm/yarn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants