adding a more meaningful user agent string

Evernote · Mar 26, 2013 · 7e8bf6b · 7e8bf6b
1 parent b26a25d
commit 7e8bf6b
Showing 1 changed file with 19 additions and 1 deletion.
diff --git a/evernote-sdk-ios/3rdParty/Thrift/transport/THTTPClient.m b/evernote-sdk-ios/3rdParty/Thrift/transport/THTTPClient.m
@@ -45,7 +45,7 @@ - (void) setupRequest
 
   NSString * userAgent = mUserAgent;
   if (!userAgent) {
-    userAgent = @"Cocoa/THTTPClient";
+    userAgent = [THTTPClient createClientVersionString];
   }
   [mRequest setValue: userAgent forHTTPHeaderField: @"User-Agent"];
 
@@ -193,5 +193,23 @@ - (void)setDownloadProgressBlock:(void (^)(NSUInteger bytesRead, long long total
     [self setDownloadProgressBlock:block];
 }
 
++ (NSString *)createClientVersionString
+{
+	NSString * clientName = nil;
+    NSString * locale = [NSString stringWithFormat: @"%@",
+                         [[NSLocale currentLocale] objectForKey: NSLocaleCountryCode]];
+
+    NSDictionary *infoDic = [[NSBundle mainBundle] infoDictionary];
+    NSString *appName = [infoDic valueForKey:(id)kCFBundleNameKey];
+    NSString * buildVersion = [infoDic valueForKey: @"SourceVersion"];
+    if (buildVersion == nil) {
+        buildVersion = [infoDic valueForKey:(id)kCFBundleVersionKey];
+    }
+    clientName = [NSString stringWithFormat: @"%@ iPhone/%@ (%@);",
+                  appName,
+                  buildVersion,
+                  locale];
+	return clientName;
+}
 
 @end