Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Paid by customer" shows wrong value in order detail #142

Open
treoden opened this issue Nov 29, 2022 · 9 comments
Open

"Paid by customer" shows wrong value in order detail #142

treoden opened this issue Nov 29, 2022 · 9 comments
Assignees

Comments

@treoden
Copy link
Collaborator

treoden commented Nov 29, 2022

No description provided.

@LOGESH-B
Copy link

@treoden Can you tell me where it shows wrong
image

@treoden
Copy link
Collaborator Author

treoden commented Jul 18, 2023

It shows wrong in order summary (grand total) from admin when user paid using Stripe
It does not effect the real amount paid by user, just the display issue

@mark-jia
Copy link
Contributor

Weired paidAmount = transaction.amount.text displays 100 x correct amount
I need to work out the flow

@mark-jia
Copy link
Contributor

Hi treoden, do you have access to the postgres database on the demo site? I was wondering if the payment_transaction has the correct data for order # 13353 and #13354? Maybe it is not a display problem. When I look through the orders, some got correct display, some not, but they all use stripe payment.

@evershopcommerce
Copy link
Collaborator

It is due to the way Stripe handles the money amount. It does not use decimal, instead it use integer. We need to devide the value by 100 before saving the transaction amount to our db

@mark-jia
Copy link
Contributor

I noticed that, how do you explain that #13350 has the correct number on the demo site?

@mark-jia
Copy link
Contributor

I noticed Stripe has 3 category and 1 special.
3 category currency: normal, zero decimal, 3 decimal currency
and there is a special

@mark-jia
Copy link
Contributor

I think I am not going to take into account of 3 decimal currency, I will assume it is a zero decimal for simplicity and just do a division by 100 as a fix, do you agree?

@mark-jia
Copy link
Contributor

what's your policy about testing, do you need to write a test script or you can pass if a very small changes?

@mark-jia mark-jia mentioned this issue Oct 28, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlogs
Development

No branches or pull requests

3 participants