Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Encountered two children with the same key, productMainImages. Keys should be unique #92

Closed
treoden opened this issue Aug 21, 2022 · 2 comments · Fixed by #96
Closed

[BUG] Encountered two children with the same key, productMainImages. Keys should be unique #92

treoden opened this issue Aug 21, 2022 · 2 comments · Fixed by #96
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@treoden
Copy link
Collaborator

treoden commented Aug 21, 2022

Describe the bug
A warning message when uploading more than 1 image when editing a product

To Reproduce
Steps to reproduce the behavior:

  1. Start project in development mode
  2. Go to admin and edit a product/create a new product
  3. Scroll down to media section and upload 2 images
  4. See error in the developer console (browser)

Expected behavior
The warning message should disappear

Screenshots
Screenshot from 2022-08-21 21-21-42
@treoden treoden added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Aug 21, 2022
@treoden treoden assigned treoden and unassigned treoden Aug 21, 2022
@gauravsahu21
Copy link

I can remove the bug

@treoden
Copy link
Collaborator Author

treoden commented Aug 21, 2022

Sure @gauravsahu21 , make a PR please

@timagixe timagixe mentioned this issue Aug 22, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Make key prop unique timagixe/evershop
2 participants
@treoden @gauravsahu21