Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ailed prop type: Invalid prop variant of value secondary supplied to Badge, expected one of ["default","success","info","attention","critical","warning","new"] #93

Closed
treoden opened this issue Aug 21, 2022 · 4 comments · Fixed by #95
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@treoden
Copy link
Collaborator

treoden commented Aug 21, 2022

Describe the bug
A warning message when visiting the order listing page from admin panel

To Reproduce
Steps to reproduce the behavior:

  1. Start the project in development mode
  2. Go to admin panel and visit the order listing page (Must have some order)
  3. See error in the developer console

Expected behavior
The error message should disappear

Screenshots
Screenshot from 2022-08-21 21-31-15

@treoden treoden added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Aug 21, 2022
@treoden treoden assigned treoden and unassigned treoden Aug 21, 2022
@timagixe
Copy link
Contributor

Hello @treoden, please assign this issue on me, I will create a PR for this issue in the next 1-2 days. Cheers!

@timagixe
Copy link
Contributor

@treoden what should be the default badge variant for pending payment status? Should it be default or which one of these - ['default', 'success', 'info', 'attention', 'critical', 'warning', 'new']?

@timagixe
Copy link
Contributor

timagixe commented Aug 22, 2022

@treoden by the default it is set to be secondary. Such a badge variant doesn't exist.

From what I see, badge variant of type secondary seems to be the result of misconfiguration/typo:

{
"name": "Pending",
"code": "pending",
"badge": "secondary",
"progress": "incomplete"
},

That's why I am clarifying what should be the variant of badge of pending status.

@timagixe timagixe mentioned this issue Aug 22, 2022
10 tasks
@timagixe
Copy link
Contributor

@treoden I have opened PR #95, which sets default badge for pending payment status.

Please let me know if it requires to be different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants