Conditional touch features, fixes #74 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure touch features are only included on ESP32 variants that supports touch. Relies on include/soc/soc_caps.h in recent versions of the IDF
Add secondary way of detecting if touch is enabled, using the 'number of touch sensors'.
evert-arias
approved these changes
Apr 26, 2023
ncmreynolds
added a commit
to ncmreynolds/EasyButton
that referenced
this pull request
May 3, 2023
Merge pull request evert-arias#78 from ncmreynolds/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ESP32 variants (C3 speciifcally) do not support touch inputs. The changes in this PR check for this rather than assuming all ESP32s support touch, before including these features.