Added return false in validator + minor docBlock

evertharmeling · Feb 1, 2019 · e32de17 · e32de17
1 parent b53ab21
commit e32de17
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/VIESApi/Validator/VATNumberValidator.php b/src/VIESApi/Validator/VATNumberValidator.php
@@ -25,6 +25,11 @@ public function __construct(Client $client)
         $this->client = $client;
     }
 
+    /**
+     * @param string $value
+     * @return bool
+     * @throws InvalidVATNumberException
+     */
     public function validate($value)
     {
         self::checkFormat($value);
@@ -34,6 +39,8 @@ public function validate($value)
 
             return true;
         } catch (VIESApiExceptionInterface $e) { }
+
+        return false;
     }
 
     /**

diff --git a/tests/VIESApi/Validator/VATNumberValidatorTest.php b/tests/VIESApi/Validator/VATNumberValidatorTest.php
@@ -2,8 +2,8 @@
 
 namespace Tests\VIESApi\Validator;
 
+use PHPUnit\Framework\Assert;
 use VIESApi\Client\Client;
-use VIESApi\Formatter\VATNumberFormatter;
 use VIESApi\Model\Country;
 use VIESApi\Validator\VATNumberValidator;
 
@@ -54,7 +54,7 @@ public function testValidVATNumbers($values)
         }
 
         foreach ($values as $value) {
-            static::assertTrue($this->getValidator()->validate($value));
+            Assert::assertTrue($this->getValidator()->validate($value));
         }
     }