Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Add support for using init.d instead of upstart #19

Closed
wants to merge 2 commits into from
Closed

Add support for using init.d instead of upstart #19

wants to merge 2 commits into from

Conversation

organicveggie
Copy link

Since upstart is not standard on RHEL flavors of Linux, this provides more typical support for using init.d. Controlled via an attribute that defaults to using upstart.

@@ -10,6 +10,10 @@
default[:exhibitor][:group] = "zookeeper"
default[:exhibitor][:install_dir] = "/opt/exhibitor"

# Upstart vs init.d
default[:exhibitor][:upstart] = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make this something like default[:exhibitor][:supervisor] = 'upstart'?

@jakedavis
Copy link
Contributor

Hiya, thanks for the PR. I dropped a few notes in; @whilp and @mwhooker in particular might have more. This is looking good, and we're keen to get cross-platform support in our cookbooks. A few tweaks should put this in a ready to go state.

@webframp
Copy link

Always great to see a PR, but based on some experience it can grow unwieldy to manage init scripts. This is why we often default to runit (when possible)

@whilp
Copy link
Contributor

whilp commented Jun 26, 2013

We also prefer runit for most stuff we write. @organicveggie would runit help get you going on non-upstart systems? If so, we might as well just switch over to that completely.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants