Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the sample app navigation #29

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

adnanjelic
Copy link
Contributor

Why

The navigation in the sample app was cumbersome to work with as it used hard-coded routes and the packaging was not well-structured

How

We improved the sample app navigation with routes defined in objects to make them more maintainable and scalable (so we do not make accidental typos and the maintenance of the navigation while adding new views is simplified).

We also did some file renaming of the screen names and repackaging some classes to make the code more maintainable and understandable

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

⚠️ No Changeset found

Latest commit: 809b4e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adnanjelic adnanjelic merged commit ede14e2 into main Oct 27, 2023
4 checks passed
@adnanjelic adnanjelic deleted the adnan/improved-sample-app-navigation branch October 27, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants