Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesis logger and config files #47

Merged
merged 6 commits into from Nov 12, 2018

Conversation

data-tech
Copy link
Contributor

Kinesis Logger with default credentials and role-based access. I have used AWS SDK for putting the records as this is the faster then KCL. For putting records as batches we can use KCL, for which we can add another logger with batching capability.

@andrewserff
Copy link
Member

Hi @data-tech, thanks for the contribution. I appoligize I've been a bit behind on the PRs out there. I just merged the other two which has now caused merge conflicts with yours. Would you be willing to fix the conflict and push it again, then I'll merge this into master. Thanks again!

@data-tech
Copy link
Contributor Author

Hi @andrewserff, I have resolved the conflicts and merged my code. Thanks.

@andrewserff andrewserff merged commit 232b915 into everwatchsolutions:master Nov 12, 2018
@andrewserff
Copy link
Member

andrewserff commented Nov 13, 2018

Hi @data-tech I just noticed after merging this that you had a dependency for the entire aws-sdk. I changed it to this:

<dependency>
            <groupId>com.amazonaws</groupId>
            <artifactId>aws-java-sdk-kinesis</artifactId>
            <version>1.11.447</version>
        </dependency>
        <dependency>
            <groupId>com.amazonaws</groupId>
            <artifactId>aws-java-sdk-sts</artifactId>
            <version>1.11.447</version>
        </dependency>

It builds, but I don't have a way to test this out. If you have time, could you test it out with that as the dependency? I'm probably going to commit it this way, so when you get a change to test, just let me know if there are issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants