V4

[danhenderson]

No description provided.

[rowanhogan]

Just a couple points

[rowanhogan]

It's a tiny pet peeve, but I find these big methods are so much easier to read when the keys are sorted alphabetically.

[danhenderson]

I'm usually the same. I think I had "title" on my mind there.

[danhenderson]

As mentioned in Slack, there were a few things tripping me up, so I'm trying to consolidate things a little bit. Here are the main changes since you last saw it.

Title and description

We are in a weird state where title and description were mixed up between Strava and Manual, and they were also called different things (e.g. message, even though it was the title, not the message...very confusing).

I went through and made everything consistently title and description (I did allow caption to passed as a fallback for title just for a bit of backwards compatibility). I also updated the create fitness form to be able to includeDescription and includeTitle.

Activity Type vs Type

This was another that was mixed, this time between the Consumer API response and GraphQL response. So I moved them explicitly up to the top to set the source and activityType correctly.

ID vs External ID vs Legacy ID

Again, this was getting very confusing between Strava/Manual (via GraphQL or Consumer, depending on whether it is being returned by GraphQL or Consumer API. I have standardised this so regardless of if you are fetching from GraphQL or Consumer API (legacy), you get the same IDs in the same fields each time.

id: this is the timeline id (null in the case of legacy only manual fitness)
externalId: this is the Strava ID
legacyId: this is the Consumer API id (only available if useLegacy: true and can be used to delete old activities)

NOTE: most of the above is specific to the JG implementation, and the only change to EDH is to follow suit w/ title and description. The id is still always the fitness entry id for EDH (ahh, simpler times).

[rowanhogan]

👍