Issues/33 ep ruby in readme #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2016 18:11
make it clear that you don't *need* to download a Popolo JSON file to use this gem, because you could use the everypolitician-ruby gem to do that for you.
|
@tmtmtmtm for review please |
| australia = Everypolitician.country('Australia') | ||
| australia.code # => "AU" | ||
| senate = australia.legislature('Senate') | ||
| senate.persons.find_by(name: "Aden Ridgeway", openaustralia: "10540") |
There was a problem hiding this comment.
I realise we have the same problem elsewhere in this file (which we should also fix), but I don't think we should show this style of searching by multiple fields in one shot as the primary example. If we want to show that you can search by more things than name, I'd suggest giving two examples, rather than one.
added 2 commits
August 30, 2016 14:40
The target is #see-also-everypolitician-ruby because that is being generated by GitHub's markdown converter.
it just confuses, let it go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the README: it's important to realise that
everypolitician-rubyexists, because this gem is useful even if you haven't manually downloaded a JSON Popolo file.