Handle unicode case folding for people's names #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmtmtmtm
force-pushed
the
casecmp
branch
4 times, most recently
from
0185c78
to
b909541
Compare
Closed
We want to use the new Unicode-friendly casecmp? which only appeared in 2.4 (and the primary user of this is a rake task in everypolitician-data, which is now on 2.4)
This handles Unicode case folding, so doesn't report that, for example, Ionel PALĂR has changed to Ionel PALĂR.
make sure that no changes are reported betweel Zoë and ZOË
Doing everything in one method is getting a little too complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't report that, for example, Ionel PALĂR has changed to Ionel PALĂR.