Retry Twitter list requests 10 times #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To try and deal with Twitter sometimes returning a 404 error for list pages this adds the Faraday "retry" middleware to the Twitter middleware stack. This is configured to check for a Twitter::Error::NotFound error and retry the request up to 10 times.
|
Have tried this in a couple of scrapers and it seems to be having the desired effect! I'm going to merge this and try updating a few scraper to see how things go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try and deal with Twitter sometimes returning a 404 error for list
pages this adds the Faraday "retry" middleware to the Twitter middleware
stack. This is configured to check for a Twitter::Error::NotFound error
and retry the request up to 10 times.
Part of everypolitician/everypolitician#610