Silence test warnings #15572
Labels
Comments
henare
added a commit
that referenced
this issue
Jan 19, 2018
Prior to Rake 11.0 Rake::TestTask warnings were disabled by default but now they're enabled. https://github.com/ruby/rake/blob/master/History.rdoc#1100--2016-03-09 >Use ruby warnings by default. Pull request # 97 by Harold Giménez We upgraded to Rake > 11.0 in: https://github.com/everypolitician/viewer-sinatra/pull/15633/files#diff-e79a60dc6b85309ae70a6ea8261eaf95R77 Now that they're enabled we need to explicitly disable them on our test task that runs the full test suite. This is because we don't yet have the test suite running cleanly without warnings, though we do want to (see #15572).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Adding
t.warning = trueto each test block in theRakefilegenerates over 20,000 warnings from arake test:allProposed Solution
Silence these, and have the warnings turned on by default.
Acceptance Criteria
rake test:alldoesn't issue any warnings witht.warning = trueenabled.Not Required
This doesn't need to (and indeed almost certainly should not) happen in a single PR. Multiple small PRs, each silencing a single class of error, is the way to go.
Prerequisites
Related Issues
#14817
Due Date
Design?
Text?
Bloggable?
The text was updated successfully, but these errors were encountered: