Add feature to modify URLs in ruleset | Fix Relative URLs #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deoxykev
changed the title
|
This will also fix #3 |
mms-gianni
reviewed
Nov 12, 2023
| replace: amp # (this would modify the domain from www.tagesspiegel.de to amp.tagesspielgel.de) | ||
| path: | ||
| - match: ^ # regex to match part of path | ||
| replace: /amp/ # (modify the url from https://www.tagesspiegel.de/internationales/ to https://www.tagesspiegel.de/amp/internationales/) |
There was a problem hiding this comment.
This is dope! I like the flexibility
|
Nice work @deoxykev ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature to modify the requested URL. This is useful for getting the AMP, Search Engine Cache or Archive site versions of a site.
The proposed ruleset API would look like this:
(this would have the effect of appending
?amp=1to the end of the requested domain.A working example has been added to fix #30
There is also an API to modify the Domain and Path of the URL by regex, which I have briefly documented in the README.md.