Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idiomatize(?) ruleset package and run lint #47

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Idiomatize(?) ruleset package and run lint #47

merged 2 commits into from
Nov 25, 2023

Conversation

dxbednarczyk
Copy link
Contributor

Fixes a usability issue in the ruleset package where the original CLI flags are used in every function instead of creating a file to write to and passing around its io.Writer.

Also runs make lint and fixes most things that golangci-lint complains about.

@mms-gianni
Copy link
Contributor

I'll need a moment to check this.

The rulesets are on the way out to a separate repository. but I'll merge it here and then migrate it to the new repository.

@ladddder
Copy link
Contributor

This breaks the functionality of RULESET=rulesets go run cmd/main.go --merge-rulesets which was printing to stdout

But this required in future build jobs in the ladder-rules repository.

@dxbednarczyk
Copy link
Contributor Author

This breaks the functionality of RULESET=rulesets go run cmd/main.go --merge-rulesets which was printing to stdout

The latest commit defaults to os.Stdout if mergeRulesetsOutput is empty. Can you confirm if it fixes the issue?

@ladddder
Copy link
Contributor

@dxbednarczyk Works perfectly now.

Tested the other 2 parameters too.

@ladddder ladddder merged commit 8f447ea into everywall:main Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants