Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Timeout #64

Merged
merged 2 commits into from
Dec 7, 2023
Merged

HTTP Timeout #64

merged 2 commits into from
Dec 7, 2023

Conversation

lutfuahmet
Copy link
Contributor

This pull request introduces a configurable timeout feature for http client. The default timeout is set to 15 seconds, but users can now modify it by utilizing the HTTP_TIMEOUT environment variable.

@mms-gianni mms-gianni merged commit 3918cf3 into everywall:main Dec 7, 2023
@dxbednarczyk
Copy link
Contributor

dxbednarczyk commented Dec 7, 2023

@mms-gianni this PR ignores the error from strconv.Atoi, if the environment variable is set to "15s" instead of just "15", the variable won't do anything. For invalid values we should warn the user that it would be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants