refactor: reduce coupling and bump to php 8 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warlof
force-pushed
the
dependencies/php/v8.x
branch
from
80fe65b
to
d094e43
Compare
remove guzzle, predis, memcache, memcached and monolog from direct dependencies of the library. use PSR packages as replacement which allow any package compliant with the standard to be used without a need to rewrite or alter eseye library. **BREAKING CHANGES** * logger MUST now implement Psr\Log\LoggerInterface instead of Seat\Eseye\Log\LogInterface * fetcher is non longer required and override to it SHOULD be applied on http_client, http_request_factory and http_stream_factory * default cache is now set on NullCache * default logger is now set on NullLogger * Seat\Eseye\Fetchers\GuzzleFetcher has been replaced by generic Seat\Eseye\Fetchers\Fetcher * minimum required PHP version is now 8.0 **TODO** * more tests * update documentation * update example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove guzzle, predis, memcache, memcached and monolog from direct dependencies of the library.
use PSR packages as replacement which allow any package compliant with the standard to be used without a need to rewrite or alter eseye library.
BREAKING CHANGES
TODO