Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rare issue where the expiration timestamp is before now() #85

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

Rakdos8
Copy link
Contributor

@Rakdos8 Rakdos8 commented Mar 20, 2023

Mainly due to delay between the call and the ESI or malformed header.
Also, some routes have a very little expiration delay (see /fleets/{fleet_id}/ or /characters/{character_id}/calendar/ routes).

A 10 seconds expiration delay looks better than no limit at all.

Error log :

==> web/log/2023-03-20-php_errors.log <==
[20/03/2023 08:24:29] Job hostname : REDACTED
[20/03/2023 08:24:29] Job batch UUID : 2c81cb6c-dd85-413d-9397-72f206065a69
[20/03/2023 08:24:29] URL: REDACTED
[20/03/2023 08:24:29] Erreur: E_UNKNOWN (0)
[20/03/2023 08:24:29] Exception: Predis\Response\ServerException
[20/03/2023 08:24:29] Message: ERR invalid expire time in setex
[20/03/2023 08:24:29] Stack trace: #0 /data/www/evemyadmin/web/vendor/predis/predis/src/Client.php(335): Predis\Client->onErrorResponse()
#1 /data/www/evemyadmin/web/vendor/predis/predis/src/Client.php(314): Predis\Client->executeCommand()
#2 /data/www/evemyadmin/web/vendor/eveseat/eseye/src/Cache/RedisCache.php(81): Predis\Client->__call()
#3 /data/www/evemyadmin/web/vendor/eveseat/eseye/src/Eseye.php(264): Seat\Eseye\Cache\RedisCache->set()
...
#10 /data/www/evemyadmin/web/class/EVEOnline/ESI/calendar/Event.php(74): EVEOnline\ESI\calendar\Event::invokeDetails()
#11 /data/www/evemyadmin/web/class/ICE_EMA/calendar/jobs/CharacterEventsJob.php(74): EVEOnline\ESI\calendar\Event::invoke()

@Rakdos8 Rakdos8 marked this pull request as draft March 20, 2023 08:26
Mainly due to delay between the call and the ESI or malformed header.
Also, some routes have a very little expiration delay (see '/fleets/{fleet_id}/' route at 5 seconds)
@Rakdos8
Copy link
Contributor Author

Rakdos8 commented Mar 20, 2023

Converting in draft for 24 hours to check if the fix is stable enough.

@Rakdos8 Rakdos8 marked this pull request as ready for review March 21, 2023 08:14
@Rakdos8
Copy link
Contributor Author

Rakdos8 commented Mar 21, 2023

Review doable, no issue/log from the past 24 hours

@warlof warlof merged commit 2a32d78 into eveseat:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants