Don't fail sde update command when network fails #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we still need to log exception if doing this. |
|
Exception logging makes sense. Try/catch can be moved around, sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I'm in school, I sometimes have some time to develop on seat modules. If I start the docker containers, it checks for a new sde, which isn't bad. My school wifi has the problem that it allows traffic to github but not to fuzzworks, meaning the command sees the new update, but can't load it and it fails, preventing me from getting the containers up. This pr fixes this, it just skips the sde update if it can't load the new sde. Being on an old sde for a few days is normally not a problem.
I made these changes a long time ago, only now I submit them as pr