Fix issue 512 related to corp tracking #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat
This reverts commit 0fdc734
warlof
reviewed
Jan 20, 2019
|
Updated, thank you for the review |
warlof
approved these changes
Jan 20, 2019
leonjza
approved these changes
Feb 15, 2019
warlof
added a commit
that referenced
this pull request
Feb 15, 2019
* fix(contracts): Remove non-existing variable from contract index (#272) * Fix corp killmails table header missarrangement (#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * Fix issue 512 related to corp tracking (#276) * Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback * Used wrong attribute for filterColumn (#277) * Fix character contracts (#279) * change `is_nan` to `is_null` * Don't be to precise * fix filter column
warlof
added a commit
that referenced
this pull request
Mar 9, 2019
* fix(contracts): Remove non-existing variable from contract index (#272) * Fix corp killmails table header missarrangement (#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * Fix issue 512 related to corp tracking (#276) * Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback * Used wrong attribute for filterColumn (#277) * Fix character contracts (#279) * change `is_nan` to `is_null` * Don't be to precise * fix filter column
warlof
pushed a commit
that referenced
this pull request
Mar 9, 2019
* Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback Closes eveseat/seat#512
warlof
added a commit
that referenced
this pull request
Mar 9, 2019
* fix(contracts): Remove non-existing variable from contract index (#272) * Fix corp killmails table header missarrangement (#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * Fix issue 512 related to corp tracking (#276) * Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback * Used wrong attribute for filterColumn (#277) * Fix character contracts (#279) * change `is_nan` to `is_null` * Don't be to precise * fix filter column
warlof
pushed a commit
that referenced
this pull request
Mar 9, 2019
* Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback Closes eveseat/seat#512
warlof
added a commit
that referenced
this pull request
Mar 9, 2019
* fix(contracts): Remove non-existing variable from contract index (#272) * Fix corp killmails table header missarrangement (#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * Fix issue 512 related to corp tracking (#276) * Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback * Used wrong attribute for filterColumn (#277) * Fix character contracts (#279) * change `is_nan` to `is_null` * Don't be to precise * fix filter column
warlof
pushed a commit
that referenced
this pull request
Mar 9, 2019
* Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback Closes eveseat/seat#512
warlof
pushed a commit
that referenced
this pull request
Mar 9, 2019
* [fix](users) Delay search to query less (#248) * [fix](ACL): inverse character permission on yourself denys access to own data (#253) * Fix inverse character permission on associated characters causing to lose access to own data. * Apply fixes from StyleCI * reuse local variable * fix(users): Reduce user coupling and avoid null exception (#251) * fix(users): Reduce user coupling and avoid null exception When an user is attached to a non existing group, the user list may crash due to some relation which are returning a null value. This is reducing coupling for an User model by using directly the group_id from the user entry and excluding things attached to group when none are returned (mails, role, etc...). Closes eveseat/seat#491 * fix(users): Fix some null exception related to orphan users in views Ensure at both login and impersonate that an user is attached to an existing group. If it's not the case, we're spawning it and update main character. Closes eveseat/seat#491 * [fix](contract): fix contract details for linked characters (#255) * Fix eveseat/seat#499 * Move route to button blade * build(core): v3.0.12 * Fix corporation contracts and add loading spinner (#263) * build(core): v3.0.13 * Queue balancing (#246) * refactor(core): Remove the old supervisor monitoring Since 3.x, the monitoring has been replaced by Horizon which is providing nice UI with load, status and jobs historic. * feat(queues): Improve server scalability using environment variables In order to make server scalability over larger infrastructure with different servers scale easier, this is using environment variables to setup Horizon daemon instead the current setting SQL table. * Corporation tracking (#250) * Fix corporation tracking and move to server side datatables * Apply fixes from StyleCI * Incooperate some of warlofs feedback: Reducing complexity in submitted parameters using array * Safe my ass from an exception due to missing user, group OR unset mainchar * encapsule labels in a div-group * better prevent null-object exception * testing the online editor * feat(mining): Reduce numbers precisions (#260) Remove the decimals from mined quantity and reduce the volume precision from 2 to 1 decimal. Closes eveseat/seat#487 * [fix](resolver): Contract filter method. Used previously the wrong attribute. (#269) * Some refactoring in the service and view to be consistant with character. (#266) Testing and closing: eveseat/seat#456 * Refactor corporation journal to work as in game. (#267) * Refactor corporation journal to work as in game. * Show 1 tab per division * refactor service trait Testing and closing: eveseat/seat#454 * warlof didn't want the D so he gets the d * Refactor view: (#268) * Test and close eveseat/seat#455 * Add Issued_by column to view * * feat(versions): Switch package versions display to generic list * fix(provider): Fix provider definition * feat(versions): Switch package versions display to generic list Instead having separate place to be able to review package version, this will provide all information into the same location, for both core and plugin packages. This will depends on a Provider update which have to be inherited by all SeAT package provider in order to be able to provide proper information and implement auto-discovery. This SeAT provider should be able to return enough information to be able to build some kind of marketplace and make plugin installation easier. * feat(versions): Implement new version management for Web package * feat(versions): Implement a version check Use packagist API to check if or not an installed package is outdated. * feat(versions): Add markdown copy-to-clipboard function Add a button near versions tab which is generating and storing into clipboard a markdown formatted table with all package vendor, name and versions from installed SeAT packages. * feat(versions): Add a footer which show global counter per state * refactor(versions): Avoid static definition * refactor(versions): Remove reflection usage and work on booted provider * feat(versions): Provide changelog directly into packages list This is providing two ways to fetch and build a changelog for a specified package : - Using directly an uri which is targetting a Markdown formatted file - Using a releases/tags API (ie: github API) The resulting changelog is then accessible by a button available near a package name. * refactor(versions): Apply initial changes according to review * feat(versions): Implement custom request validators * feat(character): Add the character name into page title * feat(character): Add the character name into page title * feat(corporation): Add the corporation name into page title * feat(header): Add a caret near profile user drop-down (#259) In order to make the user drop-down more identifiable, provide a caret near to it. Closes eveseat/seat#496 * feat(character): Move intel to asynchronous requests and improve UI * Intel-Wallet WIP * Working UniverseName function * Dispatch name and affiliation job upon access to intel-tab * Disable sorting and searching * WIP .... * Highlight inner_group_trades * Working new intel datatables * Detail Modals introduced * Top Wallet Journal * Top Wallet Transactions * Detail Modals introduced * Top Mail Interactions * Full intel controller * Add inner group wallet highlight * use search-plus favicon and refactor button blade names * Rearrange columns to fix UI bug of missing th * Review feedback implemented * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions (#262) * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions * refactor(extractions): Start to apply some change according to review * refactor(extractions): Add validator class * feat(extractions): Switch data collect to service * feat(extractions): Improve caption using translations * Add ability to filter users for valid or invalid refresh_tokens. (#271) * fix(extractions): Add breadcrumb into the layout * Issue 453 searchblade improvements (#270) * some minor refactoring and testing of: eveseat/seat#453 * sorting on a column is not triggering the id-to-name resolver; which mean corporation stay unresolved * Using generic partial blades * some minor refactoring * Using generic partial blades * disable columns for search which are irrelevant * some minor refactoring and testing of eveseat/seat#453 * Using generic partial blades * disable columns for search which are irrelevant * disable front end ordering of table as ordering is done in the query. * some minor refactoring and testing of assets eveseat/seat#453 * Using generic partial blades * some minor refactoring and testing of skill search eveseat/seat#453 * Using generic partial blades * Add modal to mail-view. Remove redundant partials * Add custom filter for recipients and from * strip html tags * build(core): v3.0.14 * 3.0.x (#283) * fix(contracts): Remove non-existing variable from contract index (#272) * Fix corp killmails table header missarrangement (#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * 3.0.x (#284) * fix(contracts): Remove non-existing variable from contract index (#272) * Fix corp killmails table header missarrangement (#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * Fix issue 512 related to corp tracking (#276) * Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback * Used wrong attribute for filterColumn (#277) * Fix character contracts (#279) * change `is_nan` to `is_null` * Don't be to precise * fix filter column * Apply fixes from StyleCI (#285) * feat(universe): Bump universe resolver to v3 which include factions (#280) * Add warning about outdated information. (#273) * Add warning about outdated information. * update text Update text for warning according to qu1ckkk's inout * Add loading spinner to changelog (#274) * Add solar_system_id to character_locations table and use in summary
warlof
pushed a commit
that referenced
this pull request
Mar 9, 2019
…king (#291) * [fix](users) Delay search to query less (#248) * [fix](ACL): inverse character permission on yourself denys access to own data (#253) * Fix inverse character permission on associated characters causing to lose access to own data. * Apply fixes from StyleCI * reuse local variable * fix(users): Reduce user coupling and avoid null exception (#251) * fix(users): Reduce user coupling and avoid null exception When an user is attached to a non existing group, the user list may crash due to some relation which are returning a null value. This is reducing coupling for an User model by using directly the group_id from the user entry and excluding things attached to group when none are returned (mails, role, etc...). Closes eveseat/seat#491 * fix(users): Fix some null exception related to orphan users in views Ensure at both login and impersonate that an user is attached to an existing group. If it's not the case, we're spawning it and update main character. Closes eveseat/seat#491 * [fix](contract): fix contract details for linked characters (#255) * Fix eveseat/seat#499 * Move route to button blade * build(core): v3.0.12 * Fix corporation contracts and add loading spinner (#263) * build(core): v3.0.13 * Queue balancing (#246) * refactor(core): Remove the old supervisor monitoring Since 3.x, the monitoring has been replaced by Horizon which is providing nice UI with load, status and jobs historic. * feat(queues): Improve server scalability using environment variables In order to make server scalability over larger infrastructure with different servers scale easier, this is using environment variables to setup Horizon daemon instead the current setting SQL table. * Corporation tracking (#250) * Fix corporation tracking and move to server side datatables * Apply fixes from StyleCI * Incooperate some of warlofs feedback: Reducing complexity in submitted parameters using array * Safe my ass from an exception due to missing user, group OR unset mainchar * encapsule labels in a div-group * better prevent null-object exception * testing the online editor * feat(mining): Reduce numbers precisions (#260) Remove the decimals from mined quantity and reduce the volume precision from 2 to 1 decimal. Closes eveseat/seat#487 * [fix](resolver): Contract filter method. Used previously the wrong attribute. (#269) * Some refactoring in the service and view to be consistant with character. (#266) Testing and closing: eveseat/seat#456 * Refactor corporation journal to work as in game. (#267) * Refactor corporation journal to work as in game. * Show 1 tab per division * refactor service trait Testing and closing: eveseat/seat#454 * warlof didn't want the D so he gets the d * Refactor view: (#268) * Test and close eveseat/seat#455 * Add Issued_by column to view * * feat(versions): Switch package versions display to generic list * fix(provider): Fix provider definition * feat(versions): Switch package versions display to generic list Instead having separate place to be able to review package version, this will provide all information into the same location, for both core and plugin packages. This will depends on a Provider update which have to be inherited by all SeAT package provider in order to be able to provide proper information and implement auto-discovery. This SeAT provider should be able to return enough information to be able to build some kind of marketplace and make plugin installation easier. * feat(versions): Implement new version management for Web package * feat(versions): Implement a version check Use packagist API to check if or not an installed package is outdated. * feat(versions): Add markdown copy-to-clipboard function Add a button near versions tab which is generating and storing into clipboard a markdown formatted table with all package vendor, name and versions from installed SeAT packages. * feat(versions): Add a footer which show global counter per state * refactor(versions): Avoid static definition * refactor(versions): Remove reflection usage and work on booted provider * feat(versions): Provide changelog directly into packages list This is providing two ways to fetch and build a changelog for a specified package : - Using directly an uri which is targetting a Markdown formatted file - Using a releases/tags API (ie: github API) The resulting changelog is then accessible by a button available near a package name. * refactor(versions): Apply initial changes according to review * feat(versions): Implement custom request validators * feat(character): Add the character name into page title * feat(character): Add the character name into page title * feat(corporation): Add the corporation name into page title * feat(header): Add a caret near profile user drop-down (#259) In order to make the user drop-down more identifiable, provide a caret near to it. Closes eveseat/seat#496 * feat(character): Move intel to asynchronous requests and improve UI * Intel-Wallet WIP * Working UniverseName function * Dispatch name and affiliation job upon access to intel-tab * Disable sorting and searching * WIP .... * Highlight inner_group_trades * Working new intel datatables * Detail Modals introduced * Top Wallet Journal * Top Wallet Transactions * Detail Modals introduced * Top Mail Interactions * Full intel controller * Add inner group wallet highlight * use search-plus favicon and refactor button blade names * Rearrange columns to fix UI bug of missing th * Review feedback implemented * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions (#262) * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions * refactor(extractions): Start to apply some change according to review * refactor(extractions): Add validator class * feat(extractions): Switch data collect to service * feat(extractions): Improve caption using translations * Add ability to filter users for valid or invalid refresh_tokens. (#271) * fix(extractions): Add breadcrumb into the layout * Issue 453 searchblade improvements (#270) * some minor refactoring and testing of: eveseat/seat#453 * sorting on a column is not triggering the id-to-name resolver; which mean corporation stay unresolved * Using generic partial blades * some minor refactoring * Using generic partial blades * disable columns for search which are irrelevant * some minor refactoring and testing of eveseat/seat#453 * Using generic partial blades * disable columns for search which are irrelevant * disable front end ordering of table as ordering is done in the query. * some minor refactoring and testing of assets eveseat/seat#453 * Using generic partial blades * some minor refactoring and testing of skill search eveseat/seat#453 * Using generic partial blades * Add modal to mail-view. Remove redundant partials * Add custom filter for recipients and from * strip html tags * build(core): v3.0.14 * 3.0.x (#283) * fix(contracts): Remove non-existing variable from contract index (#272) * Fix corp killmails table header missarrangement (#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * 3.0.x (#284) * fix(contracts): Remove non-existing variable from contract index (#272) * Fix corp killmails table header missarrangement (#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * Fix issue 512 related to corp tracking (#276) * Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback * Used wrong attribute for filterColumn (#277) * Fix character contracts (#279) * change `is_nan` to `is_null` * Don't be to precise * fix filter column * Apply fixes from StyleCI (#285) * feat(universe): Bump universe resolver to v3 which include factions (#280) * Add warning about outdated information. (#273) * Add warning about outdated information. * update text Update text for warning according to qu1ckkk's inout * Add loading spinner to changelog (#274) * Improve Tracking search: Add search on location * Apply fixes from StyleCI
herpaderpaldent
added a commit
to herpaderpaldent/web
that referenced
this pull request
Apr 22, 2019
* [fix](users) Delay search to query less (eveseat#248) * Include MailingList name, include source and refactor alliance view * [fix](ACL): inverse character permission on yourself denys access to own data (eveseat#253) * Fix inverse character permission on associated characters causing to lose access to own data. * Apply fixes from StyleCI * reuse local variable * fix(users): Reduce user coupling and avoid null exception (eveseat#251) * fix(users): Reduce user coupling and avoid null exception When an user is attached to a non existing group, the user list may crash due to some relation which are returning a null value. This is reducing coupling for an User model by using directly the group_id from the user entry and excluding things attached to group when none are returned (mails, role, etc...). Closes eveseat/seat#491 * fix(users): Fix some null exception related to orphan users in views Ensure at both login and impersonate that an user is attached to an existing group. If it's not the case, we're spawning it and update main character. Closes eveseat/seat#491 * [fix](contract): fix contract details for linked characters (eveseat#255) * Fix eveseat/seat#499 * Move route to button blade * Include mailing_list relation and remove injection * build(core): v3.0.12 * Fix corporation contracts and add loading spinner (eveseat#263) * build(core): v3.0.13 * Queue balancing (eveseat#246) * refactor(core): Remove the old supervisor monitoring Since 3.x, the monitoring has been replaced by Horizon which is providing nice UI with load, status and jobs historic. * feat(queues): Improve server scalability using environment variables In order to make server scalability over larger infrastructure with different servers scale easier, this is using environment variables to setup Horizon daemon instead the current setting SQL table. * Corporation tracking (eveseat#250) * Fix corporation tracking and move to server side datatables * Apply fixes from StyleCI * Incooperate some of warlofs feedback: Reducing complexity in submitted parameters using array * Safe my ass from an exception due to missing user, group OR unset mainchar * encapsule labels in a div-group * better prevent null-object exception * testing the online editor * feat(mining): Reduce numbers precisions (eveseat#260) Remove the decimals from mined quantity and reduce the volume precision from 2 to 1 decimal. Closes eveseat/seat#487 * [fix](resolver): Contract filter method. Used previously the wrong attribute. (eveseat#269) * Some refactoring in the service and view to be consistant with character. (eveseat#266) Testing and closing: eveseat/seat#456 * Refactor corporation journal to work as in game. (eveseat#267) * Refactor corporation journal to work as in game. * Show 1 tab per division * refactor service trait Testing and closing: eveseat/seat#454 * warlof didn't want the D so he gets the d * Refactor view: (eveseat#268) * Test and close eveseat/seat#455 * Add Issued_by column to view * * feat(versions): Switch package versions display to generic list * fix(provider): Fix provider definition * feat(versions): Switch package versions display to generic list Instead having separate place to be able to review package version, this will provide all information into the same location, for both core and plugin packages. This will depends on a Provider update which have to be inherited by all SeAT package provider in order to be able to provide proper information and implement auto-discovery. This SeAT provider should be able to return enough information to be able to build some kind of marketplace and make plugin installation easier. * feat(versions): Implement new version management for Web package * feat(versions): Implement a version check Use packagist API to check if or not an installed package is outdated. * feat(versions): Add markdown copy-to-clipboard function Add a button near versions tab which is generating and storing into clipboard a markdown formatted table with all package vendor, name and versions from installed SeAT packages. * feat(versions): Add a footer which show global counter per state * refactor(versions): Avoid static definition * refactor(versions): Remove reflection usage and work on booted provider * feat(versions): Provide changelog directly into packages list This is providing two ways to fetch and build a changelog for a specified package : - Using directly an uri which is targetting a Markdown formatted file - Using a releases/tags API (ie: github API) The resulting changelog is then accessible by a button available near a package name. * refactor(versions): Apply initial changes according to review * feat(versions): Implement custom request validators * feat(character): Add the character name into page title * feat(character): Add the character name into page title * feat(corporation): Add the corporation name into page title * feat(header): Add a caret near profile user drop-down (eveseat#259) In order to make the user drop-down more identifiable, provide a caret near to it. Closes eveseat/seat#496 * feat(character): Move intel to asynchronous requests and improve UI * Intel-Wallet WIP * Working UniverseName function * Dispatch name and affiliation job upon access to intel-tab * Disable sorting and searching * WIP .... * Highlight inner_group_trades * Working new intel datatables * Detail Modals introduced * Top Wallet Journal * Top Wallet Transactions * Detail Modals introduced * Top Mail Interactions * Full intel controller * Add inner group wallet highlight * use search-plus favicon and refactor button blade names * Rearrange columns to fix UI bug of missing th * Review feedback implemented * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions (eveseat#262) * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions * refactor(extractions): Start to apply some change according to review * refactor(extractions): Add validator class * feat(extractions): Switch data collect to service * feat(extractions): Improve caption using translations * move source to meta-info part (below timestamp) * Change `source` to `character source` * Add ability to filter users for valid or invalid refresh_tokens. (eveseat#271) * fix(extractions): Add breadcrumb into the layout * Issue 453 searchblade improvements (eveseat#270) * some minor refactoring and testing of: eveseat/seat#453 * sorting on a column is not triggering the id-to-name resolver; which mean corporation stay unresolved * Using generic partial blades * some minor refactoring * Using generic partial blades * disable columns for search which are irrelevant * some minor refactoring and testing of eveseat/seat#453 * Using generic partial blades * disable columns for search which are irrelevant * disable front end ordering of table as ordering is done in the query. * some minor refactoring and testing of assets eveseat/seat#453 * Using generic partial blades * some minor refactoring and testing of skill search eveseat/seat#453 * Using generic partial blades * Add modal to mail-view. Remove redundant partials * Add custom filter for recipients and from * strip html tags * build(core): v3.0.14 * 3.0.x (eveseat#283) * fix(contracts): Remove non-existing variable from contract index (eveseat#272) * Fix corp killmails table header missarrangement (eveseat#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * 3.0.x (eveseat#284) * fix(contracts): Remove non-existing variable from contract index (eveseat#272) * Fix corp killmails table header missarrangement (eveseat#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * Fix issue 512 related to corp tracking (eveseat#276) * Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback * Used wrong attribute for filterColumn (eveseat#277) * Fix character contracts (eveseat#279) * change `is_nan` to `is_null` * Don't be to precise * fix filter column * Apply fixes from StyleCI (eveseat#285) * feat(universe): Bump universe resolver to v3 which include factions (eveseat#280) * Add warning about outdated information. (eveseat#273) * Add warning about outdated information. * update text Update text for warning according to qu1ckkk's inout * Add loading spinner to changelog (eveseat#274) * Remove class injection from view-blade
herpaderpaldent
added a commit
to herpaderpaldent/web
that referenced
this pull request
Apr 22, 2019
) * Add ability to remove sold / bio massed characters from user_group * will create an intel note entry * intel notes are now showed in `/configuration/users/edit/` * Removing edit-section as it is unusable in SeAT 3.0 and leftover from 2.x migration. * Revert "Removing edit-section as it is unusable in SeAT 3.0 and leftover from 2.x migration." This reverts commit 9e36c26 * Fixing set-email leftover from seat 2.x and added activate use-case * Support disabled registration. * Apply fixes from StyleCI * Incooperate warlof's review * Apply fixes from StyleCI * phpDoc update * [fix](users) Delay search to query less (eveseat#248) * escape notes row to avoid html tags and provide propper rendering * Add session-info if registration has been disabled * [fix](ACL): inverse character permission on yourself denys access to own data (eveseat#253) * Fix inverse character permission on associated characters causing to lose access to own data. * Apply fixes from StyleCI * reuse local variable * fix(users): Reduce user coupling and avoid null exception (eveseat#251) * fix(users): Reduce user coupling and avoid null exception When an user is attached to a non existing group, the user list may crash due to some relation which are returning a null value. This is reducing coupling for an User model by using directly the group_id from the user entry and excluding things attached to group when none are returned (mails, role, etc...). Closes eveseat/seat#491 * fix(users): Fix some null exception related to orphan users in views Ensure at both login and impersonate that an user is attached to an existing group. If it's not the case, we're spawning it and update main character. Closes eveseat/seat#491 * [fix](contract): fix contract details for linked characters (eveseat#255) * Fix eveseat/seat#499 * Move route to button blade * build(core): v3.0.12 * Fix corporation contracts and add loading spinner (eveseat#263) * build(core): v3.0.13 * Queue balancing (eveseat#246) * refactor(core): Remove the old supervisor monitoring Since 3.x, the monitoring has been replaced by Horizon which is providing nice UI with load, status and jobs historic. * feat(queues): Improve server scalability using environment variables In order to make server scalability over larger infrastructure with different servers scale easier, this is using environment variables to setup Horizon daemon instead the current setting SQL table. * Corporation tracking (eveseat#250) * Fix corporation tracking and move to server side datatables * Apply fixes from StyleCI * Incooperate some of warlofs feedback: Reducing complexity in submitted parameters using array * Safe my ass from an exception due to missing user, group OR unset mainchar * encapsule labels in a div-group * better prevent null-object exception * testing the online editor * feat(mining): Reduce numbers precisions (eveseat#260) Remove the decimals from mined quantity and reduce the volume precision from 2 to 1 decimal. Closes eveseat/seat#487 * [fix](resolver): Contract filter method. Used previously the wrong attribute. (eveseat#269) * Some refactoring in the service and view to be consistant with character. (eveseat#266) Testing and closing: eveseat/seat#456 * Refactor corporation journal to work as in game. (eveseat#267) * Refactor corporation journal to work as in game. * Show 1 tab per division * refactor service trait Testing and closing: eveseat/seat#454 * warlof didn't want the D so he gets the d * Refactor view: (eveseat#268) * Test and close eveseat/seat#455 * Add Issued_by column to view * * feat(versions): Switch package versions display to generic list * fix(provider): Fix provider definition * feat(versions): Switch package versions display to generic list Instead having separate place to be able to review package version, this will provide all information into the same location, for both core and plugin packages. This will depends on a Provider update which have to be inherited by all SeAT package provider in order to be able to provide proper information and implement auto-discovery. This SeAT provider should be able to return enough information to be able to build some kind of marketplace and make plugin installation easier. * feat(versions): Implement new version management for Web package * feat(versions): Implement a version check Use packagist API to check if or not an installed package is outdated. * feat(versions): Add markdown copy-to-clipboard function Add a button near versions tab which is generating and storing into clipboard a markdown formatted table with all package vendor, name and versions from installed SeAT packages. * feat(versions): Add a footer which show global counter per state * refactor(versions): Avoid static definition * refactor(versions): Remove reflection usage and work on booted provider * feat(versions): Provide changelog directly into packages list This is providing two ways to fetch and build a changelog for a specified package : - Using directly an uri which is targetting a Markdown formatted file - Using a releases/tags API (ie: github API) The resulting changelog is then accessible by a button available near a package name. * refactor(versions): Apply initial changes according to review * feat(versions): Implement custom request validators * feat(character): Add the character name into page title * feat(character): Add the character name into page title * feat(corporation): Add the corporation name into page title * feat(header): Add a caret near profile user drop-down (eveseat#259) In order to make the user drop-down more identifiable, provide a caret near to it. Closes eveseat/seat#496 * feat(character): Move intel to asynchronous requests and improve UI * Intel-Wallet WIP * Working UniverseName function * Dispatch name and affiliation job upon access to intel-tab * Disable sorting and searching * WIP .... * Highlight inner_group_trades * Working new intel datatables * Detail Modals introduced * Top Wallet Journal * Top Wallet Transactions * Detail Modals introduced * Top Mail Interactions * Full intel controller * Add inner group wallet highlight * use search-plus favicon and refactor button blade names * Rearrange columns to fix UI bug of missing th * Review feedback implemented * Move to seclog and include review feedback * Apply fixes from StyleCI * merge with master * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions (eveseat#262) * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions * refactor(extractions): Start to apply some change according to review * refactor(extractions): Add validator class * feat(extractions): Switch data collect to service * feat(extractions): Improve caption using translations * Add ability to filter users for valid or invalid refresh_tokens. (eveseat#271) * fix(extractions): Add breadcrumb into the layout * Issue 453 searchblade improvements (eveseat#270) * some minor refactoring and testing of: eveseat/seat#453 * sorting on a column is not triggering the id-to-name resolver; which mean corporation stay unresolved * Using generic partial blades * some minor refactoring * Using generic partial blades * disable columns for search which are irrelevant * some minor refactoring and testing of eveseat/seat#453 * Using generic partial blades * disable columns for search which are irrelevant * disable front end ordering of table as ordering is done in the query. * some minor refactoring and testing of assets eveseat/seat#453 * Using generic partial blades * some minor refactoring and testing of skill search eveseat/seat#453 * Using generic partial blades * Add modal to mail-view. Remove redundant partials * Add custom filter for recipients and from * strip html tags * build(core): v3.0.14 * 3.0.x (eveseat#283) * fix(contracts): Remove non-existing variable from contract index (eveseat#272) * Fix corp killmails table header missarrangement (eveseat#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * 3.0.x (eveseat#284) * fix(contracts): Remove non-existing variable from contract index (eveseat#272) * Fix corp killmails table header missarrangement (eveseat#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * Fix issue 512 related to corp tracking (eveseat#276) * Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback * Used wrong attribute for filterColumn (eveseat#277) * Fix character contracts (eveseat#279) * change `is_nan` to `is_null` * Don't be to precise * fix filter column * Apply fixes from StyleCI (eveseat#285) * feat(universe): Bump universe resolver to v3 which include factions (eveseat#280) * Add warning about outdated information. (eveseat#273) * Add warning about outdated information. * update text Update text for warning according to qu1ckkk's inout * Add loading spinner to changelog (eveseat#274) * Add translation * style
herpaderpaldent
added a commit
to herpaderpaldent/web
that referenced
this pull request
Apr 22, 2019
* Mail timeline improvement (#47) * [fix](users) Delay search to query less (eveseat#248) * Include MailingList name, include source and refactor alliance view * [fix](ACL): inverse character permission on yourself denys access to own data (eveseat#253) * Fix inverse character permission on associated characters causing to lose access to own data. * Apply fixes from StyleCI * reuse local variable * fix(users): Reduce user coupling and avoid null exception (eveseat#251) * fix(users): Reduce user coupling and avoid null exception When an user is attached to a non existing group, the user list may crash due to some relation which are returning a null value. This is reducing coupling for an User model by using directly the group_id from the user entry and excluding things attached to group when none are returned (mails, role, etc...). Closes eveseat/seat#491 * fix(users): Fix some null exception related to orphan users in views Ensure at both login and impersonate that an user is attached to an existing group. If it's not the case, we're spawning it and update main character. Closes eveseat/seat#491 * [fix](contract): fix contract details for linked characters (eveseat#255) * Fix eveseat/seat#499 * Move route to button blade * Include mailing_list relation and remove injection * build(core): v3.0.12 * Fix corporation contracts and add loading spinner (eveseat#263) * build(core): v3.0.13 * Queue balancing (eveseat#246) * refactor(core): Remove the old supervisor monitoring Since 3.x, the monitoring has been replaced by Horizon which is providing nice UI with load, status and jobs historic. * feat(queues): Improve server scalability using environment variables In order to make server scalability over larger infrastructure with different servers scale easier, this is using environment variables to setup Horizon daemon instead the current setting SQL table. * Corporation tracking (eveseat#250) * Fix corporation tracking and move to server side datatables * Apply fixes from StyleCI * Incooperate some of warlofs feedback: Reducing complexity in submitted parameters using array * Safe my ass from an exception due to missing user, group OR unset mainchar * encapsule labels in a div-group * better prevent null-object exception * testing the online editor * feat(mining): Reduce numbers precisions (eveseat#260) Remove the decimals from mined quantity and reduce the volume precision from 2 to 1 decimal. Closes eveseat/seat#487 * [fix](resolver): Contract filter method. Used previously the wrong attribute. (eveseat#269) * Some refactoring in the service and view to be consistant with character. (eveseat#266) Testing and closing: eveseat/seat#456 * Refactor corporation journal to work as in game. (eveseat#267) * Refactor corporation journal to work as in game. * Show 1 tab per division * refactor service trait Testing and closing: eveseat/seat#454 * warlof didn't want the D so he gets the d * Refactor view: (eveseat#268) * Test and close eveseat/seat#455 * Add Issued_by column to view * * feat(versions): Switch package versions display to generic list * fix(provider): Fix provider definition * feat(versions): Switch package versions display to generic list Instead having separate place to be able to review package version, this will provide all information into the same location, for both core and plugin packages. This will depends on a Provider update which have to be inherited by all SeAT package provider in order to be able to provide proper information and implement auto-discovery. This SeAT provider should be able to return enough information to be able to build some kind of marketplace and make plugin installation easier. * feat(versions): Implement new version management for Web package * feat(versions): Implement a version check Use packagist API to check if or not an installed package is outdated. * feat(versions): Add markdown copy-to-clipboard function Add a button near versions tab which is generating and storing into clipboard a markdown formatted table with all package vendor, name and versions from installed SeAT packages. * feat(versions): Add a footer which show global counter per state * refactor(versions): Avoid static definition * refactor(versions): Remove reflection usage and work on booted provider * feat(versions): Provide changelog directly into packages list This is providing two ways to fetch and build a changelog for a specified package : - Using directly an uri which is targetting a Markdown formatted file - Using a releases/tags API (ie: github API) The resulting changelog is then accessible by a button available near a package name. * refactor(versions): Apply initial changes according to review * feat(versions): Implement custom request validators * feat(character): Add the character name into page title * feat(character): Add the character name into page title * feat(corporation): Add the corporation name into page title * feat(header): Add a caret near profile user drop-down (eveseat#259) In order to make the user drop-down more identifiable, provide a caret near to it. Closes eveseat/seat#496 * feat(character): Move intel to asynchronous requests and improve UI * Intel-Wallet WIP * Working UniverseName function * Dispatch name and affiliation job upon access to intel-tab * Disable sorting and searching * WIP .... * Highlight inner_group_trades * Working new intel datatables * Detail Modals introduced * Top Wallet Journal * Top Wallet Transactions * Detail Modals introduced * Top Mail Interactions * Full intel controller * Add inner group wallet highlight * use search-plus favicon and refactor button blade names * Rearrange columns to fix UI bug of missing th * Review feedback implemented * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions (eveseat#262) * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions * refactor(extractions): Start to apply some change according to review * refactor(extractions): Add validator class * feat(extractions): Switch data collect to service * feat(extractions): Improve caption using translations * move source to meta-info part (below timestamp) * Change `source` to `character source` * Add ability to filter users for valid or invalid refresh_tokens. (eveseat#271) * fix(extractions): Add breadcrumb into the layout * Issue 453 searchblade improvements (eveseat#270) * some minor refactoring and testing of: eveseat/seat#453 * sorting on a column is not triggering the id-to-name resolver; which mean corporation stay unresolved * Using generic partial blades * some minor refactoring * Using generic partial blades * disable columns for search which are irrelevant * some minor refactoring and testing of eveseat/seat#453 * Using generic partial blades * disable columns for search which are irrelevant * disable front end ordering of table as ordering is done in the query. * some minor refactoring and testing of assets eveseat/seat#453 * Using generic partial blades * some minor refactoring and testing of skill search eveseat/seat#453 * Using generic partial blades * Add modal to mail-view. Remove redundant partials * Add custom filter for recipients and from * strip html tags * build(core): v3.0.14 * 3.0.x (eveseat#283) * fix(contracts): Remove non-existing variable from contract index (eveseat#272) * Fix corp killmails table header missarrangement (eveseat#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * 3.0.x (eveseat#284) * fix(contracts): Remove non-existing variable from contract index (eveseat#272) * Fix corp killmails table header missarrangement (eveseat#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * Fix issue 512 related to corp tracking (eveseat#276) * Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback * Used wrong attribute for filterColumn (eveseat#277) * Fix character contracts (eveseat#279) * change `is_nan` to `is_null` * Don't be to precise * fix filter column * Apply fixes from StyleCI (eveseat#285) * feat(universe): Bump universe resolver to v3 which include factions (eveseat#280) * Add warning about outdated information. (eveseat#273) * Add warning about outdated information. * update text Update text for warning according to qu1ckkk's inout * Add loading spinner to changelog (eveseat#274) * Remove class injection from view-blade * Add ability to remove sold / bio massed characters from user_group (#46) * Add ability to remove sold / bio massed characters from user_group * will create an intel note entry * intel notes are now showed in `/configuration/users/edit/` * Removing edit-section as it is unusable in SeAT 3.0 and leftover from 2.x migration. * Revert "Removing edit-section as it is unusable in SeAT 3.0 and leftover from 2.x migration." This reverts commit 9e36c26 * Fixing set-email leftover from seat 2.x and added activate use-case * Support disabled registration. * Apply fixes from StyleCI * Incooperate warlof's review * Apply fixes from StyleCI * phpDoc update * [fix](users) Delay search to query less (eveseat#248) * escape notes row to avoid html tags and provide propper rendering * Add session-info if registration has been disabled * [fix](ACL): inverse character permission on yourself denys access to own data (eveseat#253) * Fix inverse character permission on associated characters causing to lose access to own data. * Apply fixes from StyleCI * reuse local variable * fix(users): Reduce user coupling and avoid null exception (eveseat#251) * fix(users): Reduce user coupling and avoid null exception When an user is attached to a non existing group, the user list may crash due to some relation which are returning a null value. This is reducing coupling for an User model by using directly the group_id from the user entry and excluding things attached to group when none are returned (mails, role, etc...). Closes eveseat/seat#491 * fix(users): Fix some null exception related to orphan users in views Ensure at both login and impersonate that an user is attached to an existing group. If it's not the case, we're spawning it and update main character. Closes eveseat/seat#491 * [fix](contract): fix contract details for linked characters (eveseat#255) * Fix eveseat/seat#499 * Move route to button blade * build(core): v3.0.12 * Fix corporation contracts and add loading spinner (eveseat#263) * build(core): v3.0.13 * Queue balancing (eveseat#246) * refactor(core): Remove the old supervisor monitoring Since 3.x, the monitoring has been replaced by Horizon which is providing nice UI with load, status and jobs historic. * feat(queues): Improve server scalability using environment variables In order to make server scalability over larger infrastructure with different servers scale easier, this is using environment variables to setup Horizon daemon instead the current setting SQL table. * Corporation tracking (eveseat#250) * Fix corporation tracking and move to server side datatables * Apply fixes from StyleCI * Incooperate some of warlofs feedback: Reducing complexity in submitted parameters using array * Safe my ass from an exception due to missing user, group OR unset mainchar * encapsule labels in a div-group * better prevent null-object exception * testing the online editor * feat(mining): Reduce numbers precisions (eveseat#260) Remove the decimals from mined quantity and reduce the volume precision from 2 to 1 decimal. Closes eveseat/seat#487 * [fix](resolver): Contract filter method. Used previously the wrong attribute. (eveseat#269) * Some refactoring in the service and view to be consistant with character. (eveseat#266) Testing and closing: eveseat/seat#456 * Refactor corporation journal to work as in game. (eveseat#267) * Refactor corporation journal to work as in game. * Show 1 tab per division * refactor service trait Testing and closing: eveseat/seat#454 * warlof didn't want the D so he gets the d * Refactor view: (eveseat#268) * Test and close eveseat/seat#455 * Add Issued_by column to view * * feat(versions): Switch package versions display to generic list * fix(provider): Fix provider definition * feat(versions): Switch package versions display to generic list Instead having separate place to be able to review package version, this will provide all information into the same location, for both core and plugin packages. This will depends on a Provider update which have to be inherited by all SeAT package provider in order to be able to provide proper information and implement auto-discovery. This SeAT provider should be able to return enough information to be able to build some kind of marketplace and make plugin installation easier. * feat(versions): Implement new version management for Web package * feat(versions): Implement a version check Use packagist API to check if or not an installed package is outdated. * feat(versions): Add markdown copy-to-clipboard function Add a button near versions tab which is generating and storing into clipboard a markdown formatted table with all package vendor, name and versions from installed SeAT packages. * feat(versions): Add a footer which show global counter per state * refactor(versions): Avoid static definition * refactor(versions): Remove reflection usage and work on booted provider * feat(versions): Provide changelog directly into packages list This is providing two ways to fetch and build a changelog for a specified package : - Using directly an uri which is targetting a Markdown formatted file - Using a releases/tags API (ie: github API) The resulting changelog is then accessible by a button available near a package name. * refactor(versions): Apply initial changes according to review * feat(versions): Implement custom request validators * feat(character): Add the character name into page title * feat(character): Add the character name into page title * feat(corporation): Add the corporation name into page title * feat(header): Add a caret near profile user drop-down (eveseat#259) In order to make the user drop-down more identifiable, provide a caret near to it. Closes eveseat/seat#496 * feat(character): Move intel to asynchronous requests and improve UI * Intel-Wallet WIP * Working UniverseName function * Dispatch name and affiliation job upon access to intel-tab * Disable sorting and searching * WIP .... * Highlight inner_group_trades * Working new intel datatables * Detail Modals introduced * Top Wallet Journal * Top Wallet Transactions * Detail Modals introduced * Top Mail Interactions * Full intel controller * Add inner group wallet highlight * use search-plus favicon and refactor button blade names * Rearrange columns to fix UI bug of missing th * Review feedback implemented * Move to seclog and include review feedback * Apply fixes from StyleCI * merge with master * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions (eveseat#262) * feat(extractions): Design an UI to retrieve pending and active moon-mining extractions * refactor(extractions): Start to apply some change according to review * refactor(extractions): Add validator class * feat(extractions): Switch data collect to service * feat(extractions): Improve caption using translations * Add ability to filter users for valid or invalid refresh_tokens. (eveseat#271) * fix(extractions): Add breadcrumb into the layout * Issue 453 searchblade improvements (eveseat#270) * some minor refactoring and testing of: eveseat/seat#453 * sorting on a column is not triggering the id-to-name resolver; which mean corporation stay unresolved * Using generic partial blades * some minor refactoring * Using generic partial blades * disable columns for search which are irrelevant * some minor refactoring and testing of eveseat/seat#453 * Using generic partial blades * disable columns for search which are irrelevant * disable front end ordering of table as ordering is done in the query. * some minor refactoring and testing of assets eveseat/seat#453 * Using generic partial blades * some minor refactoring and testing of skill search eveseat/seat#453 * Using generic partial blades * Add modal to mail-view. Remove redundant partials * Add custom filter for recipients and from * strip html tags * build(core): v3.0.14 * 3.0.x (eveseat#283) * fix(contracts): Remove non-existing variable from contract index (eveseat#272) * Fix corp killmails table header missarrangement (eveseat#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * 3.0.x (eveseat#284) * fix(contracts): Remove non-existing variable from contract index (eveseat#272) * Fix corp killmails table header missarrangement (eveseat#275) * Fix eveseat/seat#509 * Use correct order of headers and data: # date # ship # location # victim # zKB link * Fix issue 512 related to corp tracking (eveseat#276) * Add warning about outdated information. * Fix Issue 512 - Corp Tracking shows people who are not in Corporation * Don't show non-corp members in member-tracking * Remove checkbox * Introduce tabs: Valid, Invalid and Missing on Seat * Revert "Add warning about outdated information." This reverts commit 0fdc734 * Implement review feedback * Used wrong attribute for filterColumn (eveseat#277) * Fix character contracts (eveseat#279) * change `is_nan` to `is_null` * Don't be to precise * fix filter column * Apply fixes from StyleCI (eveseat#285) * feat(universe): Bump universe resolver to v3 which include factions (eveseat#280) * Add warning about outdated information. (eveseat#273) * Add warning about outdated information. * update text Update text for warning according to qu1ckkk's inout * Add loading spinner to changelog (eveseat#274) * Add translation * style * change to use herp fork (#48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue 512 - Corp Tracking shows people who are not in Corporation …
this resolves: eveseat/seat#512