Total Ratted - Dashboard Summary Stat #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonjza
reviewed
Nov 26, 2021
src/Traits/Stats.php
Outdated
| */ | ||
| public function getTotalCharacterRattingIsk(array $character_ids): ?float | ||
| { | ||
| return CharacterWalletJournal::selectRaw('SUM(amount) as total_ratting_value') |
There was a problem hiding this comment.
Any way to avoid selectRaw() here?
There was a problem hiding this comment.
☕ yeah, just late and my copy-pasta game was weak.
|
Maybe a change for the icon ? Anyway, big thanks 👍 What about coins ? |
Yeah that works, too. Done. |
warlof
reviewed
Nov 26, 2021
Yeah I really need to go to bed, lol. |
|
No hurry 🙂 |
|
@leonjza any love for this one? :) |
|
Gonna merge that this weekend at last. It's EoY and business is even more crazy with all that COVID party. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new Home statistic for total ratted stat.
Attempts to solve eveseat/seat#835
Fixed layout formatting for tablet/mobile