[breaking] Less strict in types which we accept and unified indices/coords behaviour. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored `indices` and `coords` behaviour. Removed `centercoords` variants, replaced them with `strategy` argument in relevant methods. Default behaviour is now to use `Center` everywhere. Improved online documentation by docstrings and added README to it.
Merged
visr
reviewed
Sep 5, 2021
Comment on lines
9
to
11
| A::AbstractArray{T,3} | ||
| f::AffineMap | ||
| crs::WellKnownText{GeoFormatTypes.CRS,<:String} |
There was a problem hiding this comment.
Hmm none of the three fields are concrete types, right? Is there a reason you went with that? Since normally it's best to avoid such that the compiler can specialize: https://docs.julialang.org/en/v1/manual/performance-tips/#Avoid-fields-with-abstract-type
There was a problem hiding this comment.
A is either an ArchGDAL IDataSet or an Array{T}.
AffineMap just isn't concrete, it's subs (linear and translation can be any kind of array, often StaticArrays, but not always).
WellKnownText also isn't concrete.
I'm happy to take suggestions how to resolve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
indicesandcoordsbehaviour. Removedcentercoordsvariants, replaced them withstrategyargument in relevant methods.Default behaviour is now to use
Centereverywhere.Improved online documentation by docstrings and added README to it.
Fixes #77