Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right To Left Support #50

Closed
tarek903 opened this issue Dec 13, 2016 · 10 comments
Closed

Right To Left Support #50

tarek903 opened this issue Dec 13, 2016 · 10 comments

Comments

@tarek903
Copy link

Hi,
first of all i'd like to thank you for this framework but i have a question . i there any plane for this framework to support right to left languages ?

@evgenyneu
Copy link
Owner

Hello @tarek903, good question. The reason I have not implemented it yet is because the App Store does not switch the direction of the star rating control in Arabic:

Right-to-left language rating control in App Store

I am not a right-to-left language user, so I have a question. Is it normal to keep the direction the same for the stars as in English in right-to-left language countries? Or should the star control be flipped?

@tarek903
Copy link
Author

tarek903 commented Dec 14, 2016

yea the stars should be flipped
ex:
screen shot 2016-12-14 at 12 31 15 pm

@evgenyneu
Copy link
Owner

Thanks, @tarek903, this needs to be done then.

@valentinjahanmanesh
Copy link

one approach is reversing everything, swap your empty color with fill color, and minus rank from max rank
rank is 3.5 --> 3 and half filled star and one and half empty star
==> 3.5 - 5 = 1.5 ---> one and half empty, 3 and half filled
when your swap empty and fill colors, cosmos looks like right to left 😄

@evgenyneu
Copy link
Owner

Hehe, clever hack!

@tarek903
Copy link
Author

@farshadjahanmanesh Wow .. That actually works thanks

@evgenyneu
Copy link
Owner

evgenyneu commented Jan 21, 2017

Cosmos now supports right-to-left languages from version 8.0. Thanks for your help @tarek903 and @farshadjahanmanesh. Please let me know if notice any issues.

@nemexyz
Copy link

nemexyz commented Jan 25, 2017

Hello,

Update version 8.0.1 in my project, work with an application and a framework that generates error when building it by UIApplication.shared of the RightToLeft support. Can you support framework with API extension?

captura de pantalla 2017-01-25 a las 11 53 53 a m

Thanks...

@evgenyneu
Copy link
Owner

@nemexyz, thank you for reporting this. I have removed UIApplication.shared from the code and released version 8.0.2. Let me know if it still does not compile. The side effect of this, unfortunately, is that right-to-left only works for iOS 9+.

@evgenyneu
Copy link
Owner

Closing, feel free to reopen when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants