-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use incremental parsing #772
Comments
The biggest problem with this is figuring out how to effectively store the references to individual grammar items in each item in the parse cache. Though we can certainly pickle and unpickle the cache, doing so creates new grammar objects rather than references to the existing grammar objects, which means the resulting unpickled cache is effectively useless. What we would need for this is to assign every grammar object a unique, deterministic identifier, pickle and unpickle the identifiers rather than the grammar objects themselves, then look up grammar objects by their identifier when loading in the new cache. |
|
Two things that need to be fixed with the current implementation:
|
This works now, but it only provides performance improvements for small files, so it's automatically disabled for large files. |
With the new adaptive parsing , this is now providing substantial performance improvements for all files, so it should be enabled by default (and the |
Should enable incremental parsing mode where parses are cached to improve recompilation times for slightly modified files.
The text was updated successfully, but these errors were encountered: