Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Walruses aren't allowed in places where they should be #820

Closed
kg583 opened this issue Jan 17, 2024 · 1 comment
Closed

Walruses aren't allowed in places where they should be #820

kg583 opened this issue Jan 17, 2024 · 1 comment
Labels
compatibility resolved
Milestone
v3.1.0

Comments

@kg583
Copy link

kg583 commented Jan 17, 2024

The following walruses raise parser errors, despite being valid Python:

[1, 2, 3][i := 0]
sum(i := 0 for _ in [1, 2, 3])

Note that the former only happens in a __getitem__ call; a literal like [i := 0] is parsed correctly.
@evhub evhub added this to the v3.1.0 milestone Jan 18, 2024
@evhub evhub added the resolved label Jan 18, 2024
evhub added a commit that referenced this issue Jan 18, 2024
@evhub
Fix walrus in subscripts
17ff2a3 
Resolves   #820.
@evhub
Copy link
Owner

evhub commented Jan 18, 2024

Ah, looks like I missed one of the places where 3.10 added support for named expressions. Simple workaround is to add parentheses as in <=3.9, but this should now work with --target 3.10+ as of coconut-develop>=3.0.4-post_dev15.

@evhub evhub closed this as completed Jan 18, 2024
@evhub evhub mentioned this issue Mar 1, 2024
Merged
evhub added a commit that referenced this issue Mar 2, 2024
@evhub
Release v3.1.0 (#829)
41ac855 
See Coconut's
[documentation](http://coconut.readthedocs.io/en/develop/DOCS.html) for
more information on all of the features listed below.

Language changes:
* #814: Changes to statement lambda scoping rules, including capturing
names introduced in the surrounding expression.
* #618: Changes to handling of pattern-matching function defaults
including support for e.g. `match def f(x, y=x) = (x, y)`.
* #809: New array concatenation implicit partials (e.g. `[. ; a]`).
* #823: New `(x := .)` implicit partial syntax (only available in
pipes).
* #807: New `lift_apart` built-in combinator.
* #813: New `(if)` operator function.
* #826 (thanks @JayXon!): Better universalization and `fmap` support for
`bytes` and `bytearray`.
* #816: Support for `xarray` to match existing `numpy`/`pandas` support.
* #817: New `to` argument to `all_equal`.
* #821 (thanks @GolfingSuccess!): Expanded implicit function application
syntax to support string literal methods.

Compiler changes:
* #799: `coconut-run` and `coconut --run` now work on packages rather
than just files.
* #812: Better formatting of Coconut exceptions.

Bugfixes:
* #810: Fixed an issue compiling certain syntax constructs in the
Coconut Jupyter kernel.
* #818, #825 (thanks @kg583, @dokutan!): Fixed parsing of different
Unicode line break characters.
* #822 (thanks @JayXon!): Fixed parsing of Unicode backward pipe
operators.
* #819, #820 (thanks @kg583!): Fixed some incompatibilities between
Python and Coconut syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility resolved
Projects
None yet
Milestone
v3.1.0
Development

No branches or pull requests
2 participants
@evhub @kg583