New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit unicode column names are converted to lowercase when using postgresql #478
Comments
Hi @majkinetor, I think the specific piece of code here is this line @hughess Is there a specific reason we lowercase the keys like this? |
@archiewood I actually used the same function for the postgres connector as we already had for the snowflake connector - I believe there was a reason to do that for snowflake but I'm not sure if postgres has the same requirement. @mcrascal was there a reason for lowercasing the snowflake column names in the If there's no specific reason for postgres, we should be good to remove that line |
2 other ways we can solve this issue:
|
As far as I recall, the Snowflake API returns uppercased column names, regardless of how you write your query. It was quite annoying to need to uppercase everything when referencing columns in components. Just a preference thing -- either we get all uppercase, or all lowercase. |
Ok perfect, thanks. I've just confirmed the behaviour of the postgres db package:
So I think that means we're good to remove the |
@majkinetor I've added a fix for the title formatting issue in #522. Does #522 solve your problem, or only part of it? If needed, we can fix the lowercase issue in postgres, but I'm hesitant to change that at the moment in case of unintended consequences. |
Good enough. Thank you. |
Bug Description
Serbian cyrilic:
Опис
is converted toопис
.Serbian latin:
Severity
Expected Behavior
Workarounds
There doesn't seem to be workaround
Environment Information
Operating System: Windows 10
Node version (
node -v
): 19.1.0npm version (
npm -v
): 8.9.13Package versions (
npm list --depth=0
): `@evidence-dev/evidence@5.0.12Database:
The text was updated successfully, but these errors were encountered: