-
Notifications
You must be signed in to change notification settings - Fork 2
Working slider component #4
Comments
Hey @kuatroka I think this is an ideal component to add into Evidence Labs (which is where we are hoping to put some of the more "experimental" features of evidence). https://github.com/evidence-dev/labs We'd welcome a PR there if you are open to it! You'd need to
|
Then anyone could use it if they add @evidence-dev/labs to their |
Happy to help, but I've never done any PR or a proper programming. Let me check what exactly do I need to to here.
Sorry if all of these questions are too naive, but honestly I'm not really familiar with all of this PR or other github terminology. I'm used to just copy/paste someone else's code and tweak it for my needs. Thanks |
Ah gotcha. Let me give some more detail then!
This looks like quite a good generic guide: https://github.com/firstcontributions/first-contributions |
|
You will need to push your changes to a fork of the evidence project:
https://docs.github.com/en/get-started/quickstart/fork-a-repo
You can then change which repo your local points at with `git add upstream …`
And then `got push upstream`
On June 16, 2023 at 17:13 GMT, kuatroka ***@***.******@***.***>> wrote:
1. I'm trying to push the changes (from my branch called kuatroka-branch) but getting an auth error. Not sure what to do now.
~/D/d/labs (kuatroka-branch) [128]> git push -u origin kuatroka-branch
remote: Permission to evidence-dev/labs.git denied to kuatroka.
fatal: unable to access 'https://github.com/evidence-dev/labs.git/': The requested URL returned error: 403
1. The way I've got the path to the imported component doesn't look very good to my, but the FranceMap example is the same. I've tried to use $lib but would get errors all the time.
<script>
import Slider from '../../../../../src/lib/charts/input/Slider.svelte';
let score = 8;
</script>
—
Reply to this email directly, view it on GitHub<#4 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AN3CLASFNBFVVATP5PXKG6LXLSH3FANCNFSM6AAAAAAZJOMEOQ>.
You are receiving this because you commented.Message ID: ***@***.***>
[https://bolt.im/t/?CsXtNizbg385YuNyzJSgKdK2VPdMAzBW_z4mT6IDjzZXv1OJ2-zAI0SWg86yhalr5aLLGE9X6KUc3TO6kruWPg]
|
The lib reference issue is something we need to work on.
We plan to make this better but the way you have it now is the best solution.
End users won’t need to import it all if they use the labs plug-in in evidence!
They will just be able to write <Slider/…> in their markdown
On June 16, 2023 at 17:13 GMT, kuatroka ***@***.******@***.***>> wrote:
1. I'm trying to push the changes (from my branch called kuatroka-branch) but getting an auth error. Not sure what to do now.
~/D/d/labs (kuatroka-branch) [128]> git push -u origin kuatroka-branch
remote: Permission to evidence-dev/labs.git denied to kuatroka.
fatal: unable to access 'https://github.com/evidence-dev/labs.git/': The requested URL returned error: 403
1. The way I've got the path to the imported component doesn't look very good to my, but the FranceMap example is the same. I've tried to use $lib but would get errors all the time.
<script>
import Slider from '../../../../../src/lib/charts/input/Slider.svelte';
let score = 8;
</script>
—
Reply to this email directly, view it on GitHub<#4 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AN3CLASFNBFVVATP5PXKG6LXLSH3FANCNFSM6AAAAAAZJOMEOQ>.
You are receiving this because you commented.Message ID: ***@***.***>
[https://bolt.im/t/?HXq4Ck8_aEOKN24ADcmC5TgIin8EkL2dJCLxS8KrDu9udZ7jqGvBL5d0S7Q6Xy5V56cYpSvzx24l2iBKLG9LBQ]
|
I've tried all of that, but still it errors out on me. Still the same authorisation issue.
|
How about I copy/paste the code for the two files ( Slider.svelte and index.md) here and that's it? |
Hey @kuatroka, if you paste in the code here I can add the components to labs! |
Closed by #14! 🎉 |
Feature Description
Hi, I'm not sure it should go here but I don't know under which category to file it. I've been going through your tutorial and playing with Evidence. I would like to add a small contribution in case it might be interesting to somebody. It's a working version of a simple slider that changes values in the markdown when the slider is used. It's connected to a hypothetical result of a query, so it would be fully operational for a database of file connection, not just hardcoded values. It can illustrate how a simple binding mechanism works between Evidence, Svelte in HTML
Examples
Two files are needed:
Slider.svelte
(put it incomponents
folder)test-slider.md
Screenshot
![slider](https://private-user-images.githubusercontent.com/9093546/246432436-116c872a-9eda-49d3-acdf-76349de89ef0.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzNDAyOTAsIm5iZiI6MTcyMTMzOTk5MCwicGF0aCI6Ii85MDkzNTQ2LzI0NjQzMjQzNi0xMTZjODcyYS05ZWRhLTQ5ZDMtYWNkZi03NjM0OWRlODllZjAuZ2lmP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MThUMjE1OTUwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmZiMTVkNGU2NjI3OWFjYjc1ZDE2YmJhODAxOTMzMjc3Y2ZmZmI3ZDk0NzVjZDkyYjk5OWUyN2EyYWQ2MjEyZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.tQT0utly7TO74txIC2tF1SjEFAgVQnexOi8yW0_aj3c)
The text was updated successfully, but these errors were encountered: