Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix value error messages in data drift calculations #367

Merged

Conversation

Tapot
Copy link
Contributor

@Tapot Tapot commented Oct 7, 2022

@Tapot Tapot marked this pull request as ready for review October 7, 2022 12:58
@Tapot Tapot merged commit 08fcc6f into main Oct 10, 2022
@Tapot Tapot deleted the 330-update_error_messages_for_no_values_case_in_drift_calculations branch October 14, 2022 12:10
emeli-dral added a commit that referenced this pull request Oct 26, 2022
* initial commit

* Add Fisher's exact test

* Replace MetricHtmlInfo by BaseWidgetInfo. Make id uuid by default.

* New data drift metrics (#339)

* rework data drift metrics

* fix format and imports

* fix notebooks

* add empty check after data clean for drift + some refactoring

* fix imports

* add threshold for DatasetDriftMetric
add tails in DatasetDriftMetric visual

* refactor data drift

* refactor data drift

* add tests for DatasetDriftMetric

* fix checks and titles for drift

* fix style

* update title in ColumnDriftMetric

* implement columns for DatasetDriftMetric and DataDriftTable

* fix data structure and json output for DataDriftTable

* fix data structure and json output for DatasetDriftMetric

* fix after main merge

* fix with black

* add reworked ColumnRegExpMetric (#348)

* add reworked ColumnRegExpMetric

* move ColumnRegExpMetric to a separate module, fix visual, add unittests

* fix table in html view, update an example

* fix ColumnRegExpMetric import in notebooks

* fix notebook imports

* add tabs for ColumnRegExpMetric

* fix after main merge

* fix after main merge

* fix imports with isort

* add anderson ksamp and its test

* fix doc

* fix description

* added hellinger_distance for drift detection

* isort

* Delete index.js.LICENSE.txt

* Delete index.js

* Added some examples of metrics and metric presets usage
Added some examples of tests and test presets usage
Removed outdated example with metrics

* move ColumnRegExpMetric data classes to the metric module (#360)

* fix warning about duplicated columns in data drift (#361)

* fix warning about duplicated columns in correlation calculation in data drift

* make a new list, do not modify num_feature_names

* Added the example of stattest specification for TestSuites

* Update readme.md

* Update readme.md

* add anderson example in notebook

* remove used features from wasserstein

* fix anderson not found

* check custom test

* Update all-tests.md

* Update run-tests.md

* Update run-tests.md

* Update README.md

* Add files via upload

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update examples.md

* Update examples.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* fix value error messages in data drift calculations (#367)

* fix value error messages in data drift calculations

* add error messages about missed column

* Update missing values metrics (#357)

* implement ColumnMissingValuesMetric and move DataIntegrityNullValuesMetrics to DatasetMissingValuesMetric

* fix isort and black

* fix notebook import and naming

* fix isort + black

* fix ColumnMissingValuesMetricRenderer and DatasetMissingValuesMetricRenderer

* ass sort in ColumnMissingValuesMetric

* fix ColumnMissingValuesMetric view

* fix DatasetMissingValuesMetric view

* some rename null values -> missed values

* fix flake8

* add ColumnMissingValuesMetric unit tests

* move DatasetMissingValuesMetric to a separate module

* add test_dataset_missing_values_metrics_value_error

* fix number_of_rows_with_nulls

* fix labels texts

* update notebook example

* initial commit

* Add Fisher's exact test

* Update test_stattests.py

* fix lint,sort

* Fix contingency matrix boundary cases, and add tests

* fix conflicts

* fix fisher's exact test

* fix mypy

* fix black and remove checks

Co-authored-by: Mert Bozkır <mert.bozkirr@gmail.com>
Co-authored-by: Vyacheslav Morov <v.morov@corp.mail.ru>
Co-authored-by: Tapot <novakche@yandex.ru>
Co-authored-by: inderpreetsingh01 <inderpreetsinghchhabra23@gmail.com>
Co-authored-by: inderpreetsingh01 <54892545+inderpreetsingh01@users.noreply.github.com>
Co-authored-by: Emeli Dral <emeli.dral@gmail.com>
Co-authored-by: elenasamuylova <67064421+elenasamuylova@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant