Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorry more Jade and Evil Icons questions #2

Closed
gandhiShepard opened this issue Jan 11, 2015 · 13 comments
Closed

Sorry more Jade and Evil Icons questions #2

gandhiShepard opened this issue Jan 11, 2015 · 13 comments

Comments

@gandhiShepard
Copy link

I problem that I have is with Jade nesting the path elements. This will show the outline of the eye, but not the inside of the eye. I can't figure out how to keep the paths from nesting. I added some screenshots. I'm also using Stylus. I'm not sure if that matters. Thanks! These are freaking awesome!

screen shot 2015-01-11 at 9 44 44 am
screen shot 2015-01-11 at 9 44 14 am

@gandhiShepard
Copy link
Author

The simple chevron displays fine, but the pupil inside the eye is not.

@madyankin
Copy link
Member

You have to invoke gulp-evil-icons after jade, like this:

gulp.task('default', function () {
  return gulp.src('src/index.jade')
    .pipe(jade())
    .pipe(evilIcons())
    .pipe(gulp.dest('build'));
});

@gandhiShepard
Copy link
Author

I am. Here is the task that I'm running.

gulp.task('html', ['clean:html'], function() {
return gulp.src('src/index.jade')
.pipe(isDist ? through() : plumber())
.pipe(jade({ pretty: true }))
.pipe(evilIcons())
.pipe(rename('index.html'))
.pipe(gulp.dest('dist'))
.pipe(reload({stream:true}));
});

@madyankin
Copy link
Member

I'll check this, thank you for the report.

@gandhiShepard
Copy link
Author

For what it's worth, I'm making a presentation using Bespoke.js. This is the environment that I'm using Evil Icons in.

@gandhiShepard
Copy link
Author

I'm using it in Jade like this:

li 
  icon(name="ei-heart" size="s") 
  a(href="http://evil-icons.io/") Evil Icons

@madyankin
Copy link
Member

I can't reproduce this http://img.madyankin.name/jI2Xz.png.
Could you show me a minimal example of your jade code (with doctype and such things)?

@madyankin
Copy link
Member

And it would be nice to see the compiled html.

@gandhiShepard
Copy link
Author

@madyankin
Copy link
Member

I've fixed this, thank you for the report and for your help. The new version is accessible in npm.

@gandhiShepard
Copy link
Author

What was the issue? Just curios incase I run into something similar in jade.

@gandhiShepard
Copy link
Author

ALSO...thanks! Stay awesome!

@madyankin
Copy link
Member

Cheerio, the html parser, was too smart to break the output html. I've replaced it with a couple of good old regular expressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants