-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Item Secondary Stats #147
Comments
Indeed - and exactly how to show them is a very huge issue. I'll see if I can figure something out. |
Dont forget to consider the case when there are more than 2 stats (or no secondary stats, or 1 stat) on the item. Currently it only occurs on the legendary items, but for completeness and for the future, do consider that. |
Haven't found a good way to do this. I'm also not sure how usable this is anyway. Closing. |
Can you show the secondary stats (Critical/Mastery/Versatility/Haste) of the item in white text (These stats is colored in white in tooltip, so I recommend to color them in white text) in votingframe and the lootframe? The value doesn't need to be shown. This could be very convenient.
Some adjustment to other widget is needed.
Sample display is
Critical/Mastery
(The stat with higher value is shown first, more crit than mastery)Mastery/Critical
(More mastery than crit)WoW API for this feature:
GetItemStats
(Item needs to be cached)Constants:
ITEM_MOD_HASTE_RATING_SHORT
ITEM_MOD_MASTERY_RATING_SHORT
ITEM_MOD_CRIT_RATING_SHORT
ITEM_MOD_VERSATILITY
These constants is the key of the table returned by GetItemStats.
Its localized text can be fetched from , for example, _G["ITEM_MOD_HASTE_RATING_SHORT"]
Not a difficult feature to implement, the issue is just how to properly adjust the display.
The text was updated successfully, but these errors were encountered: