Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Item Secondary Stats #147

Closed
SafeteeWoW opened this issue Jan 19, 2018 · 4 comments
Closed

Show Item Secondary Stats #147

SafeteeWoW opened this issue Jan 19, 2018 · 4 comments

Comments

@SafeteeWoW
Copy link
Contributor

SafeteeWoW commented Jan 19, 2018

Can you show the secondary stats (Critical/Mastery/Versatility/Haste) of the item in white text (These stats is colored in white in tooltip, so I recommend to color them in white text) in votingframe and the lootframe? The value doesn't need to be shown. This could be very convenient.

Some adjustment to other widget is needed.

Sample display is
Critical/Mastery (The stat with higher value is shown first, more crit than mastery)
Mastery/Critical (More mastery than crit)

WoW API for this feature:

  1. GetItemStats (Item needs to be cached)

Constants:

  1. ITEM_MOD_HASTE_RATING_SHORT
  2. ITEM_MOD_MASTERY_RATING_SHORT
  3. ITEM_MOD_CRIT_RATING_SHORT
  4. ITEM_MOD_VERSATILITY
    These constants is the key of the table returned by GetItemStats.
    Its localized text can be fetched from , for example, _G["ITEM_MOD_HASTE_RATING_SHORT"]

Not a difficult feature to implement, the issue is just how to properly adjust the display.

@SafeteeWoW SafeteeWoW changed the title Show text secondary stats Show Item Secondary Stats Jan 19, 2018
@evil-morfar
Copy link
Owner

Indeed - and exactly how to show them is a very huge issue. I'll see if I can figure something out.

@SafeteeWoW
Copy link
Contributor Author

SafeteeWoW commented Jan 19, 2018

Dont forget to consider the case when there are more than 2 stats (or no secondary stats, or 1 stat) on the item. Currently it only occurs on the legendary items, but for completeness and for the future, do consider that.

@evil-morfar evil-morfar mentioned this issue Jan 24, 2018
9 tasks
@evil-morfar
Copy link
Owner

I've tried a few different things, none of which I liked. My best result was with putting it over the item icon (ignore the "out of bounds" text, this was just the only picture I saved):
image

I'm not sure how useful this really is anyway..

@evil-morfar
Copy link
Owner

Haven't found a good way to do this. I'm also not sure how usable this is anyway. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants