Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat command changes #148

Closed
evil-morfar opened this issue Jan 19, 2018 · 2 comments
Closed

Chat command changes #148

evil-morfar opened this issue Jan 19, 2018 · 2 comments

Comments

@evil-morfar
Copy link
Owner

I've been postponing this for a while, but finally got around to do it. I might as well do it properly while I'm at it, so here's a short heads up for v2.7.6:

I wanted to enhance the formatting of the output by colorizing the command, hence a need to change to current structure. I created a new function (RCLootCouncil:ModuleChatCmd()) so it doesn't overlap with the old format, which is still supported.

Here's the implementation from GroupGear to make the switch whenever the user upgrades:

if addon:VersionCompare(addon.version, "2.7.6") then
   addon:CustomChatCmd(self, "Show", "- gg - Show the GroupGear window (alt. 'groupgear' or 'gear')", "gg", "groupgear", "gear")
else
   addon:ModuleChatCmd(self, "Show", nil, "Show the GroupGear window (alt. 'groupgear' or 'gear')", "gg", "groupgear", "gear")
end
@SafeteeWoW
Copy link
Contributor

I will go and update EPGP module when 2.7.6 is close to ready.
Progressing on Mythic Argus and want to kill him before Lunar Festival, so not going to write big changes.

@SafeteeWoW
Copy link
Contributor

Uploaded RCLootCouncil-EPGP v2.2.3 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants