Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify the player when the bag is full #156

Open
SafeteeWoW opened this issue Mar 15, 2018 · 1 comment
Open

Notify the player when the bag is full #156

SafeteeWoW opened this issue Mar 15, 2018 · 1 comment

Comments

@SafeteeWoW
Copy link
Contributor

SafeteeWoW commented Mar 15, 2018

If the player has no free space to carry the item being rolled.

  1. All non-pass buttons will be grey out and disabled.
  2. Mouseover any button (include PASS) shows a tooltip to tell the player to clean the bag. OR change the ilvl text or item name text to tell the player about this?
  3. When the bag has free space, button will be enabled again.

After this change, ML will rarely fail his loot distribution because some1's bag is full.

Side effect: This could slow down the response process.
So alternatively and more easier, we can choose not to bother with the buttons, and one of the following:

  1. Give a big warning when non-pass response is chosen while the bag is full.
  2. Big text in the title of the loot frame when the bag is full.
@SafeteeWoW SafeteeWoW changed the title Make Non-pass response not clickable if bag is full Notify the player when the bag is full Mar 15, 2018
@evil-morfar
Copy link
Owner

evil-morfar commented Mar 15, 2018

Both suggestions could potentially cause an "unable to award" due to filled bags. With the first, player has 1 free space, and wins two items. With the second he could just ignore it, or maybe even just fail to clear his bags in time.

I don't really want to disable buttons due to full bags - it could take some time to clear out.
Doing some warning text is possible, but then why not just print something to chat?

Either way, I'd very much prefer to relay some information back to the ML. This could be done when awarding (like the current checks, except the candidate sends a "bags_full" comm so we know for certain), or simply just send it whenever our bags are full. I imagine the latter being more reliable, but way more costly. Edit: Probably not if it's only done when we receive a lootTable, and if an award fails, we almost know for sure his bags are full and can use that for the fail message, otherwise we just ignore it.

@evil-morfar evil-morfar mentioned this issue Mar 26, 2018
9 tasks
@evil-morfar evil-morfar added v2.9 and removed v2.8 labels Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants