Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Создал Dockerfile и убедился что он собирает контейнер, и собирает/запускает проект, и что все ок рабоатет на сервере.
Пока делал, понял что в dependencies должны лежать не только что нужно для рантайма, но и то что нужно для сборки. (вот тут годно объяснено webpack/webpack#520 (comment)) Так что все осторожно перенес.
Еще я решил, что задавать переменные окружения (например NODE_ENV) в package.json таки нехорошо.