Not sure how to classify this - terminal output errors when starting Mylar

[DGMayor]

Started a few days ago after a commit, but didn't really notice it until yesterday. Last night's commit had no effect on it, so here it is..

04-Aug-2013 06:58:18 - INFO :: MainThread : Mylar is restarting...
INFO:mylar:MainThread : Mylar is restarting...
04-Aug-2013 06:58:18 - INFO :: MainThread : Restarting Mylar with ['C:\Python27\python.exe', 'C:\Mylar\Mylar.py', '--nolaunch']
INFO:mylar:MainThread : Restarting Mylar with ['C:\Python27\python.exe', 'C:\Mylar\Mylar.py', '--nolaunch']
04-Aug-2013 06:58:18 - INFO :: MainThread : Checking to see if the database has all tables....
04-Aug-2013 06:58:18 - INFO :: MainThread : Populating Base Exception listings into Mylar....
04-Aug-2013 06:58:18 - INFO :: MainThread : Populating Custom Exception listings into Mylar....
04-Aug-2013 06:58:18 - INFO :: MainThread : Ensuring DB integrity - Removing all Erroneous Comics (ie. named None)
04-Aug-2013 06:58:18 - INFO :: MainThread : Correcting Null entries that make the main page break on startup.
04-Aug-2013 06:58:18 - INFO :: MainThread : Retrieving latest version information from github
04-Aug-2013 06:58:19 - INFO :: MainThread : Comparing currently installed version with latest github version
04-Aug-2013 06:58:19 - INFO :: MainThread : Mylar is up to date
04-Aug-2013 06:58:19 - INFO :: MainThread : CVAPIFIX enabled: ComicVine set to beta API site
04-Aug-2013 06:58:19 - INFO :: MainThread : Remapping the sorting to allow for new additions.
04-Aug-2013 06:58:19 - INFO :: MainThread : Sucessfully ordered 126 series in your watchlist.
04-Aug-2013 06:58:20 - INFO :: MainThread : Starting Mylar on port: 8090
04-Aug-2013 06:58:20 - INFO :: MainThread : Initiating startup-RSS feed checks.
04-Aug-2013 06:58:20 - INFO :: MainThread : RSS Feed Check was last run at : 2013-08-04 06:53:14
04-Aug-2013 06:58:20 - INFO :: MainThread : Checking for existance of Weekly Comic listing...
04-Aug-2013 06:58:20 - INFO :: Thread-12 : Weekly pull list present - checking if it's up-to-date..
04-Aug-2013 06:58:21 - INFO :: Thread-12 : No new pull-list available - will re-check again in 24 hours.
04-Aug-2013 06:58:21 - INFO :: Thread-12 : Checking the Weekly Releases list for comics I'm watching...
04-Aug-2013 06:58:21 - INFO :: Thread-12 : Found comic directory: p:\comics/Marvel/X-Men Legacy (2013)
04-Aug-2013 06:58:21 - INFO :: Thread-12 : Volume information found! Adding to series record : volume 2
04-Aug-2013 06:58:21 - INFO :: Thread-12 : Now adding/updating: X-Men: Legacy
04-Aug-2013 06:58:21 - INFO :: Thread-12 : Sucessfully retrieved details for X-Men: Legacy
04-Aug-2013 06:58:21 - INFO :: Thread-12 : Directory (p:\comics/Marvel/X-Men Legacy (2013)) already exists! Continuing...
04-Aug-2013 06:58:21 - INFO :: Thread-12 : Sucessfully retrieved cover for X-Men: Legacy
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Sucessfully retrieved issue details for X-Men: Legacy
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Now adding/updating issues for X-Men: Legacy
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Updating complete for: X-Men: Legacy
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Now checking files for X-Men: Legacy
(2013) in p:\comics/Marvel/X-Men Legacy (2013)
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Total files located: 13
04-Aug-2013 06:58:22 - INFO :: Thread-12 : I've physically found 13 issues, ignored 0 issues, and accounted for 0 in an Archived state. Total Issue Count: 13 / 14
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Found comic directory: p:\comics\DC Comics\Batman Incorporated (2012)
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Volume information found! Adding to series record : volume 2
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Now adding/updating: Batman, Incorporated
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Sucessfully retrieved details for Batman, Incorporated
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Directory (p:\comics\DC Comics\Batman Incorporated (2012)) already exists! Continuing...
04-Aug-2013 06:58:22 - INFO :: Thread-12 : Sucessfully retrieved cover for Batman, Incorporated
04-Aug-2013 06:58:23 - INFO :: Thread-12 : Sucessfully retrieved issue details for Batman, Incorporated
04-Aug-2013 06:58:23 - INFO :: Thread-12 : Now adding/updating issues for Batman, Incorporated
04-Aug-2013 06:58:23 - INFO :: Thread-12 : Updating complete for: Batman, Incorporated
04-Aug-2013 06:58:23 - INFO :: Thread-12 : Now checking files for Batman, Incorporated (2012) in p:\comics\DC Comics\Batman Incorporated (2012)
Exception in thread Thread-12:
Traceback (most recent call last):
File "C:\Python27\lib\threading.py", line 808, in __bootstrap_inner
self.run()
File "C:\Python27\lib\threading.py", line 761, in run
self.__target(_self.__args, *_self.__kwargs)
File "C:\Mylar\mylar\weeklypull.py", line 142, in pullit
pullitcheck()
File "C:\Mylar\mylar\weeklypull.py", line 556, in pullitcheck
statusupdate = updater.upcoming_update(ComicID=ComicID, ComicName=ComicName,
IssueNumber=ComicIssue, IssueDate=ComicDate, forcecheck=forcecheck)
File "C:\Mylar\mylar\updater.py", line 179, in upcoming_update
else: mylar.importer.addComictoDB(ComicID,mismatch,pullupd)
File "C:\Mylar\mylar\importer.py", line 761, in addComictoDB
updater.forceRescan(comicid)
File "C:\Mylar\mylar\updater.py", line 513, in forceRescan
fcdigit = helpers.issuedigits(fcnew[som])
File "C:\Mylar\mylar\helpers.py", line 690, in issuedigits
int_issnum = (int(issno) * 1000) + ordtot
ValueError: invalid literal for int() with base 10: ''

[uspider7]

Having a similar issue on the "Recheck files" button in the comic series.

Exception in thread Thread-14: Traceback (most recent call last): File "C:\Python27\lib\threading.py", line 530, in __bootstrap_inner self.run() File "C:\Python27\lib\threading.py", line 483, in run self.__target(*self.__args, **self.__kwargs) File "C:\mylar-development\mylar\updater.py", line 513, in forceRescan fcdigit = helpers.issuedigits(fcnew[som]) File "C:\mylar-development\mylar\helpers.py", line 690, in issuedigits int_issnum = (int(issno) * 1000) + ordtot ValueError: invalid literal for int() with base 10:

So far, it's been every comic I've tried.

In the logs, it's flagging that I have a special character in the name; " # " was not an issue before, is there a naming convention that should be followed?

04-Aug-2013 10:06:58 - DEBUG :: Thread-15 : we should remove 1 characters 04-Aug-2013 10:06:58 - DEBUG :: Thread-15 : detected 1 special characters 04-Aug-2013 10:06:58 - DEBUG :: Thread-15 : special character appears outside of title - ignoring @ position: 26

I did try to remove the "#" from one of the series, but that didn't help, the character log did go away, but the comics were not rechecked and updated in the GUI.

Thanks

[evilhero]

I'm not sure why but no matter what I do I can't reproduce the error, and I've tried quite abit. I'm starting to think that somehow it's a Windows vs. Linux thing just because everyone thus far whose mentioned the issue is running windows. Are you guys on the latest development commit?

[DGMayor]

Yup, latest version.

I just did a Refresh Comic on Action Comics (2011) and it turned all files to skipped. when I clicked on recheck files, the terminal output is as follows (partially the same as above):

04-Aug-2013 12:01:37 - INFO :: CP Server Thread-3 : Now checking files for Action Comics (2011) in p:\comics\DC Comics\Action Comics (2011)
04-Aug-2013 12:02:09 - INFO :: Thread-28 : Now checking files for Action Comics (2011) in p:\comics\DC Comics\Action Comics (2011)
Exception in thread Thread-28:
Traceback (most recent call last):
File "C:\Python27\lib\threading.py", line 808, in __bootstrap_inner
self.run()
File "C:\Python27\lib\threading.py", line 761, in run
self.__target(_self.__args, *_self.__kwargs)
File "C:\Mylar\mylar\updater.py", line 513, in forceRescan
fcdigit = helpers.issuedigits(fcnew[som])
File "C:\Mylar\mylar\helpers.py", line 690, in issuedigits
int_issnum = (int(issno) * 1000) + ordtot
ValueError: invalid literal for int() with base 10: ''

[evilhero]

In the mylar.log file, right before that error occurs it references 2 variables.. tsord and issno. The tsord should contain just alphanumerics (if they exist) and issno is supposed to contain just digits. It's trying to take the integer value of a non-digit somehow so I need to see what that value is.

The reasoning why this was done in this manner is that with issues coming out lately with alphanumerics (AU, AI, A, B, etc) this process will account for all of these variations on the fly so no special fixes would need to be done.. It's just a matter of finding out what that character is that's screwing things up in these error messages.

[ajw107]

Wow, coincidentally I've just submitted a patch to you for this exact
problem. Doesn't seem to have been posted yet though. Should I copy
and paste it in this thread?
Alex

On 04/08/2013 17:49, evilhero wrote:

In the mylar.log file, right before that error occurs it references 2
variables.. tsord and issno. The tsord should contain just
alphanumerics (if they exist) and issno is supposed to contain just
digits. It's trying to take the integer value of a non-digit somehow
so I need to see what that value is.

The reasoning why this was done in this manner is that with issues
coming out lately with alphanumerics (AU, AI, A, B, etc) this process
will account for all of these variations on the fly so no special
fixes would need to be done.. It's just a matter of finding out what
that character us that's screwing things up in these error messages.

—
Reply to this email directly or view it on GitHub
#497 (comment).

[ajw107]

Forgot to mention, the patch is Issue #499 in the issues list.
Alex

On 04/08/2013 19:55, Alex Wood wrote:

Wow, coincidentally I've just submitted a patch to you for this exact
problem. Doesn't seem to have been posted yet though. Should I copy
and paste it in this thread?
Alex

On 04/08/2013 17:49, evilhero wrote:

In the mylar.log file, right before that error occurs it references 2
variables.. tsord and issno. The tsord should contain just
alphanumerics (if they exist) and issno is supposed to contain just
digits. It's trying to take the integer value of a non-digit somehow
so I need to see what that value is.

The reasoning why this was done in this manner is that with issues
coming out lately with alphanumerics (AU, AI, A, B, etc) this process
will account for all of these variations on the fly so no special
fixes would need to be done.. It's just a matter of finding out what
that character us that's screwing things up in these error messages.

—
Reply to this email directly or view it on GitHub
#497 (comment).

[evilhero]

The patch submitted will just cleanse the filename in a much better way than is done currently (kudos BTW, I'll look over it more and explain what I was doing when I'm in front of a machine - if I can remember what I was doing. But anything that's done to clear up that mess so just the issue # gets passed is always a big plus).
The issue herein, where it states about the ordinal and integer is when it's comparing issue #'s that have been passed from the filechecker (the temploc variable) against the issue # in the db (updater.py).

[ajw107]

Ah right, I get you. I did stay away from doing anything with the DB in
my patch (do mention it as a way of properly processing Issue Titles,
especially when no Issue Number is given). If the issue is actually
present in the DBie it's not a case of the error is being caused by the
issue number being too high, then this may also help here if the issue
title is added to the filename. But that depends on exactly why the
error is occurring. If there's anything I can do to help, please let me
know.
Alex

On 04/08/2013 20:16, evilhero wrote:

The patch submitted will just cleanse the filename in a much better
way than is done currently (kudos BTW, I'll look over it more and
explain what I was doing when I'm in front of a machine - if I can
remember. But anything that's done to clear up that mess so just the
issue # gets passed is always big plus).
The issue herein, where it states about the ordinal and integer is
when it's comparing issue #'s that have been passed from the
filechecker (the temploc variable) against the issue # in the db
(updater.py).

—
Reply to this email directly or view it on GitHub
#497 (comment).

[DGMayor]

Not sure if it's tied to this, but post processing is now broken as well. I thought maybe it was comictagger so I disabled it and re-downloaded a file, but same error. Found about 26 comics sitting in my download folder this evening..

http://paste2.org/y93j2dp6

[evilhero]

No it's actually because Mylar doesn't do a direct number comparison when trying to match issue numbers. It converts it into an integer and then uses that throughout the whole process when it comes to matching. The last few commits had something I was working on, and while it works fine on my machine, others are having some major problems with it. What it does is :

takes the integer value of the issue number

and if the issue number contains an alphanumeric or decimal, then it attempts to take the ordinal value of each letter within the issue, and add that to the initial issue number integer value to get a final unique integer number.

I do believe your filecheck fix may address the problem of the extra space (or whatever character it is), that's getting piped through and Mylar is attempting to take the integer value of it and it's resulting in an error. From what I'm gleaning, it's not a problem with the issue data from the db, it's a problem with the filename and the way it's getting parsed through.

I see you took it from a few commits ago, so I'm gonna run through some quick sims against the series' that I know are usually headaches for this type of stuff and see how we can get it all working nicely again, whether by using your code entirely, or a portion of it - either way, much thanks for the work in this :)

[evilhero]

Well, I tried as is with Batman Incorporated just to see if I could replicate the problem and was able to (finally). I then added in Alex's changes and for sure, it worked and detected them just fine.

I then tried the Uncanny X-Men (2013) series, and well, it gave the error that's currently happening with it - which has to do with the '-' within the series...I'm looking at it now, so suffice to say, Alex's code will be added in in the next commit (tonight), and the X-Men thing will be working by then too :)

[DGMayor]

Tada~

[DGMayor]

So I just did a manual refresh on Superior Spider-Man (one with the AU issues) and it choked. I have 1-14 including 6 AU and it shows 1-5 downloaded, 6, 6AU-10 skipped, and 11-14 as wanted.

Exact same thing for Uncanny Avengers. downloaded up to the issue before the # with an AU, skipped those, wanted for the rest. (1-7 downloaded, 8/8 AU skipped, 9 & 10 wanted). I have them all.

[DGMayor]

I'm going to go ahead and close this one again since the issue is actually being discussed in #499