Sorting Numeric columns broken as of last checkin

[rupaschomaker]

Sorting is being done lexically rather than numerically. So we have

1
10
11
12
2
21
22

etc rather than
1
2
10
11
12
21
22

I see this in:

/home - Last Issue
/upcoming - Issue
/pullist - number (this is the most annoying one since I use this to check for new titles I might be interested in)
/history - Issue

[rupaschomaker]

Actually probably after the last mass checkin, I'm not familiar enough with how this is done on the client side to figure out whats up -- but if I find it sooner rather than later I'll send a patch.

[evilhero]

Yeah, it's because those are based on the string value of the issue number (as was done prior to a fix). The problem is that the pullist is based on a string value, so getting an integer may prove to be abit cumbersome but it can be done. The history, upcoming and home screens however it's a fairly easy fix (use int_issuenumber instead of issue_number). I'll see about getting a fix up since I have a few other bug fixes to send up today.

[rupaschomaker]

ah, cool, thanks. I poked around and this part doesn't really make sense to me so I'll let you handle it.

[evilhero]

Well I got it working for the Upcoming and Pullist pages, the home page though is proving to be a bit of a challenge for some reason since the formatting gets lost somewhere.. I'm still looking into it though.

As a bonus, I figured out the formatting problem with annuals that occured when changing the status of any issue of a series that has annuals (and annuals are enabled), it would unformat the issues list and just make it unreadable for the most part. This was the main reason why the annuals weren't enabled by default, so yay!

[rupaschomaker]

Did this get lost in the merge issue you had earlier? I tried sorting pullist by Number and it is sorted lexically rather than numerically. Tried making a small mod to do it myself but my python foo isn't strong enough to get it working. :(

[evilhero]

Yeah, unfortunately the changes I had made on my local repo for this wasn't pushed up before I lost it all - so I'll have to start again. At least I know how to do it now (which is a good thing sometimes), I'll queue it up so it'll be in the next commit probably in a few days.