Don't update counters twice if non-slotted counter #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envek
requested changes
Jan 12, 2023
There was a problem hiding this comment.
Thanks a lot for the pull request with the fix!
You have checked “I've added tests for this change” checkbox, but I can't see any test changes in this pull request, perhaps you forgot to commit it?
And don't hesitate to add a change log entry praising you 😉
Also optional nitpick below ↓
danielwestendorf
force-pushed
the
master
branch
from
3db2eab
to
f8334b0
Compare
|
Sorry, I was in a hurry and just threw the PR up quickly. I've revised.
Thanks for the gem! |
Envek
approved these changes
Jan 12, 2023
egor-lukin
approved these changes
Jan 13, 2023
|
Thanks! Released in 0.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fix compatibility with non-slotted counter cache columns
Fixes #9
What changes did you make? (overview)
Don't double increment when a counter column is not registered as a slotted counter
Is there anything you'd like reviewers to focus on?
Checklist